feat(clerk-js,shared): Remove expired_token retry flow#8108
Draft
nikosdouvlis wants to merge 1 commit intomainfrom
Draft
feat(clerk-js,shared): Remove expired_token retry flow#8108nikosdouvlis wants to merge 1 commit intomainfrom
nikosdouvlis wants to merge 1 commit intomainfrom
Conversation
The previous session token is now always sent in the /tokens POST body (via the `token` param), so the backend no longer needs to request it via a 422 missing_expired_token error and retry. Removes: - MissingExpiredTokenError class and its re-export from @clerk/shared - The catch-and-retry logic in Session.#createTokenResolver - 4 related tests in Session.test.ts
🦋 Changeset detectedLatest commit: 3eb6e94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The previous session token is now always sent in the
/tokensPOST body (via thetokenparam in #8105), so the backend no longer needs to request it via a 422missing_expired_tokenerror and a retry with?expired_token=<jwt>in the query string.This also removes JWT leakage from query strings. The old flow sent the full JWT as a URL search param, which is visible in access logs, proxies, and referrer headers. The new
tokenbody param avoids this.What
MissingExpiredTokenErrorclass from@clerk/sharedSession.#createTokenResolverNote:
isUnauthenticatedErrorstill treats 422 as unauthenticated. This is left as-is for now since other 422 error codes may still indicate invalid session state.Test plan