fix(clerk-js): reset Core 3 OAuth retry state#8494
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: bf22549 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis pull request addresses Core 3 OAuth retry routing in Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Fixes SDK-75.
signIn.__internal_future.sso()reused an existing sign-in resource when one already had an id. After a user backed out of an OAuth provider (browser back button on Google's consent screen), the resource still held the previous provider'sexternalVerificationRedirectURL, so a later click on a different provider sent them back to the original consent screen.The fix drops implicit reuse from
sso()so it always starts fresh, matching what the plain OAuth path already did. Also resets the async resource fetch status when restoring a pending task from BFCache, which was leaving subsequent attempts stuck.