Skip to content

Improved playback recovery#47

Merged
iambalaam merged 5 commits into
mainfrom
improved-playback-recovery
Apr 16, 2026
Merged

Improved playback recovery#47
iambalaam merged 5 commits into
mainfrom
improved-playback-recovery

Conversation

@iambalaam
Copy link
Copy Markdown
Contributor

  • Improved flow of assertTemporalProperties
    • I have separated all the cases into 'behaviors'
    • Each behavior should be initiated from idle and should always go back to idle
  • Added a new behaviour for seeking ahead when playbackRate adjustment is disabled
  • Added small optimisation to avoid pausing media
  • Removed seeked event listners in favour of polling HTMLMediaElement.seeked

@iambalaam iambalaam requested a review from tomdixon April 10, 2026 11:39
Comment thread packages/javascript/src/state-based/MediaClipManager.ts Outdated
Comment thread packages/javascript/src/state-based/MediaClipManager.ts
Copy link
Copy Markdown
Contributor

@tomdixon tomdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iambalaam iambalaam merged commit 1dbdcb3 into main Apr 16, 2026
5 checks passed
@iambalaam iambalaam deleted the improved-playback-recovery branch April 16, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants