Skip to content

Ensuring Date override always returns integer#52

Merged
iambalaam merged 1 commit into
mainfrom
timesync-integer-Date-now
May 6, 2026
Merged

Ensuring Date override always returns integer#52
iambalaam merged 1 commit into
mainfrom
timesync-integer-Date-now

Conversation

@iambalaam
Copy link
Copy Markdown
Contributor

  • I think this is the correct place to perform rounding, as it is only to do with Date.now()
  • For example the rest of the timesync logic could work with higher precision (performance.now()), but only Date.now() should be integer.

@iambalaam iambalaam requested a review from chetbox May 6, 2026 09:03
Comment thread packages/timesync/src/setDate.ts
@iambalaam iambalaam merged commit aac9303 into main May 6, 2026
5 checks passed
@iambalaam iambalaam deleted the timesync-integer-Date-now branch May 6, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants