Adding a warning for mismatched COGS and cogs-client versions#54
Merged
Conversation
tomdixon
reviewed
May 12, 2026
| // From cogs-client@3.0.0 legacy media events are no longer supported. | ||
| // COGS will continue sending them with an added 'media_strategy' field for backwards compatibility. | ||
| // If media_strategy is not present, the user is attempting to use a new cogs-client with an old COGS. | ||
| case 'audio_play': |
Contributor
There was a problem hiding this comment.
Could this not just be the default handler rather than specifying the message types here?
Contributor
Author
There was a problem hiding this comment.
Currently there are also these that don't need any warning
case 'show_reset':
case 'text_hints_update':
case 'cogs_environment':
case 'media_state':
And I'm assuming that in future it'll be a pain to add a new message, then have to remember that you have to opt-out of a warning
tomdixon
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested Using
cogs-sdkonmainand current COGS in production5.9Action
Leads to console warning
(now says
cogs-clientnotcogs-client-react)