Add post-transfer disk checksum verification#406
Merged
Dany9966 merged 1 commit intocloudbase:masterfrom Apr 14, 2026
Merged
Conversation
claudiubelu
force-pushed
the
adds-checksum
branch
from
80008c7 to
17170a5
Compare
Dany9966
requested changes
Apr 7, 2026
claudiubelu
force-pushed
the
adds-checksum
branch
3 times, most recently
from
e14d59a to
8bedf10
Compare
Dany9966
requested changes
Apr 9, 2026
After each disk is written, compare the source (replicator) and
destination (writer) checksums to catch any data corruption during
transfer. The comparison happens while the writer device is still
acquired so the checksum job can run.
- Client.get_disk_checksum: calls GET /api/v1/dev/{disk}/checksum
- HTTPBackupWriterImpl:
- _create_checksum_job: calls POST /api/v2/device/{disk}/checksumJob
- _delete_checksum_job: calls DELETE /api/v2/device/{disk}/checksumJob/{id}
- _get_checksum_job_status: calls GET /api/v2/device/{disk}/checksumJob/{id}
- get_disk_checksum: creates checksum job, waits for it to finish, and
returns the checksum value and algorithm.
- Replicator._verify_disk_checksum: compares both sides, raises on
algorithm or value mismatch.
claudiubelu
force-pushed
the
adds-checksum
branch
from
8bedf10 to
f3ccc28
Compare
Dany9966
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After each disk is written, compare the source (replicator) and destination (writer) checksums to catch any data corruption during transfer. The comparison happens while the writer device is still acquired so the checksum job can run.
Client.get_disk_checksum: calls GET/api/v1/dev/{disk}/checksumHTTPBackupWriterImpl:_create_checksum_job: calls POST/api/v2/device/{disk}/checksumJob_delete_checksum_job: calls DELETE/api/v2/device/{disk}/checksumJob/{id}-
_get_checksum_job_status: calls GET/api/v2/device/{disk}/checksumJob/{id}get_disk_checksum: creates checksum job, waits for it to finish, and returns the checksum value and algorithm.Replicator._verify_disk_checksum: compares both sides, raises on algorithm or value mismatch.