Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Clean installs fail across the workspace
After
@modelcontextprotocol/sdkchanges to 1.31.0,npm cirejects the unchanged root lockfile. The lockfile still pins 1.30.0 for the think workspace, so CI stops before any checks run.Learn more
The root lockfile records both the think workspace's dependency and its installed SDK version as 1.30.0. CI runs
npm cithrough Install dependencies, which requires the lockfile to match every workspace manifest. This version change makes that install fail in every CI job before the build and typecheck steps.Example: A clean checkout runs
npm ciat the repository root. It finds 1.31.0 in the think manifest but only 1.30.0 in the lockfile and exits instead of installing dependencies.Recommended fix: Regenerate and commit the root
package-lock.jsonfor the updated workspace dependency, then verifynpm cisucceeds from a clean checkout.Was this helpful? React with 👍 or 👎 to provide feedback.