Skip to content

Refactor bitbucket#1787

Open
prymitive wants to merge 1 commit intomainfrom
bb
Open

Refactor bitbucket#1787
prymitive wants to merge 1 commit intomainfrom
bb

Conversation

@prymitive
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.80.0-45-g59826a53
Number of rules parsed 9
Number of rules checked 9
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
                    │   old.txt   │              new.txt               │
                    │   sec/op    │   sec/op     vs base               │
GlobFinder-4          19.41m ± 2%   19.17m ± 7%       ~ (p=0.315 n=10)
GitFinder-4           368.4m ± 1%   367.6m ± 1%       ~ (p=0.075 n=10)
CheckRules-4           9.629 ± 1%    9.630 ± 1%       ~ (p=0.912 n=10)
RuleIsIdentical-4     6.460m ± 2%   6.436m ± 2%       ~ (p=0.165 n=10)
GetChecksForEntry-4   112.6m ± 0%   114.3m ± 1%  +1.48% (p=0.000 n=10)
geomean               138.0m        137.9m       -0.06%

                    │    old.txt     │                new.txt                │
                    │      B/op      │     B/op      vs base                 │
GlobFinder-4          7.109Mi ± 0%     7.109Mi ± 0%       ~ (p=0.912 n=10)
GitFinder-4           15.74Mi ± 1%     15.74Mi ± 1%       ~ (p=0.796 n=10)
CheckRules-4          889.0Mi ± 0%     889.9Mi ± 0%       ~ (p=0.315 n=10)
RuleIsIdentical-4       0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
GetChecksForEntry-4   56.84Mi ± 0%     56.84Mi ± 0%       ~ (p=0.448 n=10)
geomean                            ²                 +0.02%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                    │    old.txt    │               new.txt                │
                    │   allocs/op   │  allocs/op   vs base                 │
GlobFinder-4          110.6k ± 0%     110.6k ± 0%       ~ (p=0.263 n=10)
GitFinder-4           142.9k ± 0%     142.9k ± 0%       ~ (p=0.197 n=10)
CheckRules-4          9.712M ± 0%     9.714M ± 0%       ~ (p=0.190 n=10)
RuleIsIdentical-4      0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=10) ¹
GetChecksForEntry-4   927.9k ± 0%     927.9k ± 0%       ~ (p=0.381 n=10)
geomean                           ²                +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/cloudflare/pint/internal/parser
        │   old.txt   │              new.txt               │
        │   sec/op    │   sec/op     vs base               │
Parse-4   16.32m ± 2%   16.43m ± 1%  +0.72% (p=0.043 n=10)

        │   old.txt    │            new.txt             │
        │     B/op     │     B/op      vs base          │
Parse-4   6.386Mi ± 0%   6.386Mi ± 0%  ~ (p=0.698 n=10)

        │   old.txt   │            new.txt            │
        │  allocs/op  │  allocs/op   vs base          │
Parse-4   102.8k ± 0%   102.8k ± 0%  ~ (p=1.000 n=10)

pkg: github.com/cloudflare/pint/internal/parser/source
               │   old.txt   │              new.txt               │
               │   sec/op    │   sec/op     vs base               │
LabelsSource-4   7.379m ± 1%   7.549m ± 1%  +2.31% (p=0.001 n=10)

               │   old.txt    │            new.txt             │
               │     B/op     │     B/op      vs base          │
LabelsSource-4   5.702Mi ± 0%   5.700Mi ± 0%  ~ (p=0.218 n=10)

               │   old.txt   │            new.txt            │
               │  allocs/op  │  allocs/op   vs base          │
LabelsSource-4   46.76k ± 0%   46.76k ± 0%  ~ (p=0.114 n=10)

pkg: github.com/cloudflare/pint/internal/promapi
                    │   old.txt   │            new.txt            │
                    │   sec/op    │   sec/op     vs base          │
QueryCacheOnlySet-4   105.2n ± 1%   104.8n ± 1%  ~ (p=0.897 n=10)

                    │  old.txt   │            new.txt             │
                    │    B/op    │    B/op     vs base            │
QueryCacheOnlySet-4   64.00 ± 0%   64.00 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

                    │  old.txt   │            new.txt             │
                    │ allocs/op  │ allocs/op   vs base            │
QueryCacheOnlySet-4   1.000 ± 0%   1.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.47%. Comparing base (e37e017) to head (59826a5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1787      +/-   ##
==========================================
- Coverage   99.53%   99.47%   -0.06%     
==========================================
  Files         113      112       -1     
  Lines       13729    13359     -370     
==========================================
- Hits        13665    13289     -376     
- Misses         35       38       +3     
- Partials       29       32       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -1,4 +1,3 @@
http response bitbucket /rest/insights/1.0/projects/prometheus/repos/rules/commits/.*/reports/pint 200 OK
http response bitbucket /rest/api/1.0/projects/prometheus/repos/rules/commits/.*/pull-requests 200 {}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants