Repository navigation
[internal][recipe] Add JRuby -> Ruby mapping - #128
Merged
Merged
Conversation
benjaminguttmann-avtq
requested review from
a team
and
a balanced review from Copilot
November 5, 2026 09:20
There was a problem hiding this comment.
🟡 Changes recommended
The newly accepted JRuby 10.x versions cannot compile because the build still selects JDK 8 rather than the required Java 21 or later.
1 open issue
What changed in this PR
Extends the binary builder’s JRuby-to-Ruby compatibility mapping to recognize newer JRuby series.
Changes:
- Maps JRuby 10.0 to Ruby 3.4 and JRuby 10.1 to Ruby 4.0.
- Preserves the existing JRuby 9.3 and 9.4 mappings.
| File | Description |
|---|---|
internal/recipe/jruby.go |
Adds compatibility mappings for JRuby 10.0 and 10.1. |
Review effort: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
Mocked downloads and command execution cannot verify the JDK 21 bootstrap checksum or establish JRuby 10.0/10.1 build and runtime compatibility, leaving real Docker/network validation on both stacks outstanding.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
rkoster
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add the mapping from JRuby to Ruby, so we are able to introduce new JRuby Versions:
https://www.jruby.org/download
JRuby 10.x requires Java 21+, but the recipe always used the stack's
JDK 8 and a pinned Maven 3.6.3, so builds for the newly mapped 10.0/10.1
versions would fail at compile time.
9.x keeps JDK 8 + Maven 3.6.3, 10.x uses JDK 21 + Maven 3.9.9
BootstrapConfig.JRubyJDK21 (installs to /opt/java21)
and the JDK 21 stack config