Repository navigation
Harden source release URL checks - #536
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the changes to release URL redirect handling and curl error reporting.
No open issues 🎉
What changed in this PR
Updates source-release URL checks to validate redirect destinations and display curl errors on failure.
Changes:
- Adds
--locationto follow redirects. - Adds
--show-errorwhile preserving HEAD requests,--fail, and exit-on-failure behavior.
| File | Description |
|---|---|
ci/tasks/utils.sh |
Updates the release-check helper to follow redirects and expose curl diagnostics. |
Review effort: Balanced
Source-release URL checks accept bosh.io redirects without validating the download destination, suppress curl diagnostics, and fail immediately on transient errors. Follow redirects and show errors while retaining HEAD requests and
--fail. Retry transient failures up to three times, with a 10-second connection timeout and a 60-second limit per attempt.Validation:
bash -n ci/tasks/utils.shandgit diff --checkpassed. The updated helper succeeded against CredHub 2.15.28 through its S3 redirect with the retry and timeout options enabled.