Skip to content

Harden source release URL checks - #536

Merged
Alphasite merged 6 commits into
developfrom
fix-bosh-io-release-url-check
Oct 29, 2026
Merged

Alphasite merged 6 commits into
developfrom
fix-bosh-io-release-url-check

Conversation

@Alphasite

@Alphasite Alphasite commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Source-release URL checks accept bosh.io redirects without validating the download destination, suppress curl diagnostics, and fail immediately on transient errors. Follow redirects and show errors while retaining HEAD requests and --fail. Retry transient failures up to three times, with a 10-second connection timeout and a 60-second limit per attempt.

Validation: bash -n ci/tasks/utils.sh and git diff --check passed. The updated helper succeeded against CredHub 2.15.28 through its S3 redirect with the retry and timeout options enabled.

Copilot AI balanced review requested due to automatic review settings October 29, 2026 20:58
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b8ba5f77-8038-4d3c-bdbb-662fb1929402

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the changes to release URL redirect handling and curl error reporting.

No open issues 🎉

What changed in this PR

Updates source-release URL checks to validate redirect destinations and display curl errors on failure.

Changes:

  • Adds --location to follow redirects.
  • Adds --show-error while preserving HEAD requests, --fail, and exit-on-failure behavior.
File Description
ci/​tasks/​utils.sh Updates the release-check helper to follow redirects and expose curl diagnostics.

Review effort: Balanced

@Alphasite Alphasite changed the title Follow redirects and show errors when checking source releases Harden source release URL checks Oct 29, 2026
@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Oct 29, 2026
@Alphasite
Alphasite merged commit 90c08ea into develop Oct 29, 2026
3 checks passed
@Alphasite
Alphasite deleted the fix-bosh-io-release-url-check branch October 29, 2026 21:56
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants