Skip to content

Follow the bosh-deployment default branch - #185

Merged
aramprice merged 2 commits into
mainfrom
codex/bosh-deployment-main
Nov 3, 2026
Merged

aramprice merged 2 commits into
mainfrom
codex/bosh-deployment-main

Conversation

@aramprice

@aramprice aramprice commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Remove the explicit master selector from read-only bosh-deployment Git sources, allowing them to follow the repository default before and after its rename. These changes can be merged and applied while the default is still master.

Concourse Git resource contract: a read-only source can follow the default by omitting branch; a write source requires an explicit branch.

Validation: git diff --check passed. Exact parsed before/after comparison confirms only the intended Git source branch selectors changed. Modern strict offline pipeline validation reports the same existing template/legacy-schema errors before and after; runtime compatibility requires operator verification.

Only checked-in definitions are changed. Deployed pipeline reconfiguration and runtime checks remain operator-owned. No Concourse pause/unpause, configuration, cache clearing, resource checks, job triggers or configure-script execution were performed.

Cutover steps, consumer readiness and rollback: cloudfoundry/bosh-deployment#539

Community configuration (draft): cloudfoundry/community#1686

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The bosh-deployment Git resource in ci/pipeline.yml no longer specifies branch: master. The comment in ci/tasks/windows/bbl-up.sh also no longer identifies the pipeline copy as “(master).”

Suggested reviewers: selzoc

Merge Risk: Minimal · up to 7ee23

The pipeline will follow the bosh-deployment default branch, with no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title states the main change: the bosh-deployment Git sources no longer pin master and now follow the repository default branch. The raw summary confirms this change in ci/pipeline.yml, with a m…
Description check Passed The description is closely related to the changeset. It explains that the explicit master selector is removed from read-only bosh-deployment Git sources, and it describes the validation and the scop…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: the bosh-deployment Git sources no longer pin master and now follow the repository default branch. The raw summary confirms this change in ci/pipeline.yml, with a matching comment update in ci/tasks/windows/bbl-up.sh.

Full details: Description check

Explanation

The description is closely related to the changeset. It explains that the explicit master selector is removed from read-only bosh-deployment Git sources, and it describes the validation and the scope limits. This matches the raw summary of the ci/pipeline.yml and ci/tasks/windows/bbl-up.sh changes.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 87157125-ed5c-4ceb-b009-6f6edda83dd3
Commits

Reviewing files that changed from the base of the PR and between c8fbc97 and 7ee23d3.

Files selected for processing: 1
  • ci/tasks/windows/bbl-up.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Nov 3, 2026
@aramprice
aramprice merged commit eba3266 into main Nov 3, 2026
20 checks passed
@aramprice
aramprice deleted the codex/bosh-deployment-main branch November 3, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant