Repository navigation
Make staging.auth optional instead of mandatory - #5567
Merged
Merged
Conversation
kathap
marked this pull request as draft
October 22, 2026 10:40
2 of 3 tasks
kathap
marked this pull request as ready for review
October 22, 2026 11:44
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Oct 29, 2026
Changes in cloud_controller_ng:
- Make staging.auth optional instead of mandatory
PR: cloudfoundry/cloud_controller_ng#5567
Author: Katharina Przybill <30441792+kathap@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Make staging.auth optional in all four ccng config schemas (api, worker, clock, deployment_updater).
An explanation of the use cases your change solves
staging.auth (backed by BOSH properties cc.staging_upload_user/password) is only used by the local blobstore (local/local-temp-storage blobstore types, where local? = true). The local blobstore is only meaningful for local development — in a real BOSH deployment there is always more than one CC instance, so a local blobstore cannot be shared. All supported BOSH deployments use storage-cli (e.g. DAV, Azure, S3), where local? = false and staging.auth is never consulted. Making the field optional allows BOSH deployments to omit staging.auth from the config (once capi-release stops rendering it) without failing schema validation, while local dev setups that still supply it continue to work unchanged.
Links to any other associated PRs
Remove local blobstore support from capi-release capi-release#710
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests