Skip to content

Refactor deployment layout and colocate broker registration errands - #2

Merged
rkoster merged 11 commits into
mainfrom
refactor-deployment-manifests
Oct 29, 2026
Merged

rkoster merged 11 commits into
mainfrom
refactor-deployment-manifests

Conversation

@rkoster

@rkoster rkoster commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Base / dependency

Stacked on #1: this PR targets add-cf-volume-acceptance. After #1 merges, rebase this branch and switch the base to main.

Summary

  • Consolidate manifests, operations, and runtime configs under deployment/.
  • Extract singleton Postgres/WebDAV backends, certificates, credentials, and aliases into non-HA validation ops; let the base manifest accept external backend objects.
  • Separate CF volume-service enablement, validation DNS aliases, and shared Cloud Controller endpoint configuration under deployment/operations/cf/.
  • Add an instant-bosh-only DNS addon workaround referencing existing global certificates without declaring DNS variables.
  • Colocate register-broker and deregister-broker as errands on the JuiceFS broker group, consuming the local broker and shared CF endpoint links.
  • Update acceptance orchestration, Devbox deployment, Azure ops, and documentation for the new layout and registration commands.

Validation

  • Interpolated base, singleton-validation, instant-bosh DNS/credentials, and acceptance configurations.
  • Verified backend startup ordering, colocated errand lifecycles, shared CF endpoint, and absence of duplicate DNS variable declarations.
  • Interpolated external backend ops and Azure runtime-config ops.
  • Validated Devbox JSON, workflow actionlint, shell syntax, and diff whitespace.

Full live acceptance will run on this PR; these changes have not yet been deployed.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 14:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The relocated errands lack CF API DNS resolution, and the Azure deployment instructions need ordering and environment-specific corrections.

3 open issues
What changed in this PR

This PR consolidates JuiceFS deployment configuration under deployment/, separates optional validation backends from the base manifest, and moves broker registration errands onto the JuiceFS broker VM.

Changes:

  • Extract singleton backends and environment-specific DNS and credentials into ops files.
  • Colocate registration errands and consume CF’s shared endpoint link.
  • Update deployment scripts, acceptance orchestration, Azure configuration, and documentation.
File Description
scripts/​acceptance/​run Updates deployment ordering, paths, and registration invocation.
README.md Documents the new layout and deployment procedure.
operations/​enable-juicefs-cf-volume-service.yml Removes the combined CF configuration and standalone errands.
manifests/​juicefs.yml Removes the former bundled deployment manifest.
docs/​azure-managed-identities.md Updates Azure deployment paths and commands.
docs/​acceptance-testing.md Documents revised DNS setup and registration.
devbox.json Updates local deployment orchestration.
deployment/​runtime-configs/​README.md Explains standard and instant-bosh DNS setup.
deployment/​runtime-configs/​juicefs-volume-driver.yml Relocates the CF volume-driver runtime-config.
deployment/​runtime-configs/​azure-managed-identities.yml Updates the target-path comment.
deployment/​operations/​use-mysql-s3.yml Relocates external MySQL/S3 configuration.
deployment/​operations/​use-azure-managed-identities.yml Adds the BPM release dependency for Azure configuration.
deployment/​operations/​use-azure-blob.yml Relocates Azure Blob configuration.
deployment/​operations/​use-azure-blob-managed-identity.yml Relocates identity-based Azure Blob configuration.
deployment/​operations/​non-ha-validation.yml Adds optional singleton backends, aliases, and credentials.
deployment/​operations/​misc/​ibosh-cf-credentials.yml Reuses instant-bosh CF credentials.
deployment/​operations/​misc/​ibosh-bosh-dns-fix.yml Adds JuiceFS-side DNS using existing certificates.
deployment/​operations/​instant-bosh-acceptance.yml Adjusts acceptance release overrides.
deployment/​operations/​expand-backend-disk.yml Relocates backend disk configuration.
deployment/​operations/​enable-juicefs-acceptance-tests.yml Allows adding the JuiceFS release entry.
deployment/​operations/​cf/​share-cloud-controller.yml Publishes CF’s HTTPS endpoint link.
deployment/​operations/​cf/​non-ha-validation.yml Adds CF-side validation backend aliases.
deployment/​operations/​cf/​enable-volume-services.yml Separates CAPI volume-service enablement.
deployment/​juicefs.yml Adds the external-backend base manifest and colocated errands.
AGENTS.md Updates deployment guidance and registration commands.

Review effort: Balanced

Comment thread docs/azure-managed-identities.md Resolved
Comment thread docs/azure-managed-identities.md Resolved
@rkoster
rkoster requested review from a team, aramprice, beyhan and wayneeseguin and removed request for a team, beyhan and wayneeseguin October 26, 2026 16:24
@rkoster
rkoster added this pull request to stack #3 October 27, 2026 08:19

@jorbaum jorbaum left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have one minor comment. We should wait for #1 and other reviews.

Comment thread AGENTS.md Resolved
Base automatically changed from add-cf-volume-acceptance to main October 27, 2026 14:48
@rkoster
rkoster force-pushed the refactor-deployment-manifests branch from a60e895 to d14c695 Compare October 27, 2026 14:48
@rkoster
rkoster requested a review from jorbaum October 28, 2026 09:50
@rkoster
rkoster merged commit 6919740 into main Oct 29, 2026
2 checks passed
@rkoster
rkoster deleted the refactor-deployment-manifests branch October 29, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants