Repository navigation
Refactor deployment layout and colocate broker registration errands - #2
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The relocated errands lack CF API DNS resolution, and the Azure deployment instructions need ordering and environment-specific corrections.
3 open issues
What changed in this PR
This PR consolidates JuiceFS deployment configuration under deployment/, separates optional validation backends from the base manifest, and moves broker registration errands onto the JuiceFS broker VM.
Changes:
- Extract singleton backends and environment-specific DNS and credentials into ops files.
- Colocate registration errands and consume CF’s shared endpoint link.
- Update deployment scripts, acceptance orchestration, Azure configuration, and documentation.
| File | Description |
|---|---|
| scripts/acceptance/run | Updates deployment ordering, paths, and registration invocation. |
| README.md | Documents the new layout and deployment procedure. |
| operations/enable-juicefs-cf-volume-service.yml | Removes the combined CF configuration and standalone errands. |
| manifests/juicefs.yml | Removes the former bundled deployment manifest. |
| docs/azure-managed-identities.md | Updates Azure deployment paths and commands. |
| docs/acceptance-testing.md | Documents revised DNS setup and registration. |
| devbox.json | Updates local deployment orchestration. |
| deployment/runtime-configs/README.md | Explains standard and instant-bosh DNS setup. |
| deployment/runtime-configs/juicefs-volume-driver.yml | Relocates the CF volume-driver runtime-config. |
| deployment/runtime-configs/azure-managed-identities.yml | Updates the target-path comment. |
| deployment/operations/use-mysql-s3.yml | Relocates external MySQL/S3 configuration. |
| deployment/operations/use-azure-managed-identities.yml | Adds the BPM release dependency for Azure configuration. |
| deployment/operations/use-azure-blob.yml | Relocates Azure Blob configuration. |
| deployment/operations/use-azure-blob-managed-identity.yml | Relocates identity-based Azure Blob configuration. |
| deployment/operations/non-ha-validation.yml | Adds optional singleton backends, aliases, and credentials. |
| deployment/operations/misc/ibosh-cf-credentials.yml | Reuses instant-bosh CF credentials. |
| deployment/operations/misc/ibosh-bosh-dns-fix.yml | Adds JuiceFS-side DNS using existing certificates. |
| deployment/operations/instant-bosh-acceptance.yml | Adjusts acceptance release overrides. |
| deployment/operations/expand-backend-disk.yml | Relocates backend disk configuration. |
| deployment/operations/enable-juicefs-acceptance-tests.yml | Allows adding the JuiceFS release entry. |
| deployment/operations/cf/share-cloud-controller.yml | Publishes CF’s HTTPS endpoint link. |
| deployment/operations/cf/non-ha-validation.yml | Adds CF-side validation backend aliases. |
| deployment/operations/cf/enable-volume-services.yml | Separates CAPI volume-service enablement. |
| deployment/juicefs.yml | Adds the external-backend base manifest and colocated errands. |
| AGENTS.md | Updates deployment guidance and registration commands. |
Review effort: Balanced
rkoster
requested review from
a team,
aramprice,
beyhan and
wayneeseguin
and removed request for
a team,
beyhan and
wayneeseguin
October 26, 2026 16:24
rkoster
force-pushed
the
refactor-deployment-manifests
branch
from
October 27, 2026 14:48
a60e895 to
d14c695
Compare
jorbaum
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Base / dependency
Stacked on #1: this PR targets
add-cf-volume-acceptance. After #1 merges, rebase this branch and switch the base tomain.Summary
deployment/.deployment/operations/cf/.Validation
Full live acceptance will run on this PR; these changes have not yet been deployed.