Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The instant-bosh deployment exits before deploying JuiceFS because its domain lookup targets api instead of control, with additional issues in compatibility guidance and test execution.
4 open issues
What changed in this PR
This PR makes JuiceFS’s default Cloud Foundry configuration target upstream cf-deployment, while separating instant-bosh compatibility settings.
Changes:
- Target standard CF instance groups by default and add explicit instant-bosh variants.
- Add deployment interpolation tests, fixtures, vendored YAML support, and CI integration.
- Update deployment guidance and clarify that Devbox is optional.
| File | Description |
|---|---|
| scripts/test-deployment | Adds the deployment-test entry point. |
| scripts/deploy | Updates domain lookup and selects compatibility files. |
| scripts/acceptance/run | Selects instant-bosh configurations explicitly. |
| README.md | Updates prerequisites, deployment guidance, and test commands. |
| docs/azure-managed-identities.md | Documents standard CF targets and instant-bosh differences. |
| deployment/tests/vendor/modules.txt | Records the vendored YAML dependency. |
| deployment/tests/vendor/gopkg.in/yaml.v3/yamlprivateh.go | Vendors YAML character helpers. |
| deployment/tests/vendor/gopkg.in/yaml.v3/yamlh.go | Vendors YAML internal types. |
| deployment/tests/vendor/gopkg.in/yaml.v3/yaml.go | Vendors the YAML public API. |
| deployment/tests/vendor/gopkg.in/yaml.v3/writerc.go | Vendors YAML output buffering. |
| deployment/tests/vendor/gopkg.in/yaml.v3/sorter.go | Vendors YAML key ordering. |
| deployment/tests/vendor/gopkg.in/yaml.v3/resolve.go | Vendors YAML scalar resolution. |
| deployment/tests/vendor/gopkg.in/yaml.v3/README.md | Includes dependency documentation. |
| deployment/tests/vendor/gopkg.in/yaml.v3/readerc.go | Vendors YAML input decoding. |
| deployment/tests/vendor/gopkg.in/yaml.v3/parserc.go | Vendors YAML parsing. |
| deployment/tests/vendor/gopkg.in/yaml.v3/NOTICE | Includes dependency notices. |
| deployment/tests/vendor/gopkg.in/yaml.v3/LICENSE | Includes dependency licenses. |
| deployment/tests/vendor/gopkg.in/yaml.v3/encode.go | Vendors YAML encoding. |
| deployment/tests/vendor/gopkg.in/yaml.v3/decode.go | Vendors YAML decoding. |
| deployment/tests/vendor/gopkg.in/yaml.v3/apic.go | Vendors YAML parser and emitter helpers. |
| deployment/tests/README.md | Documents deployment-test usage. |
| deployment/tests/operations_test.go | Checks targets, aliases, runtime scopes, and errand VM types. |
| deployment/tests/go.sum | Adds test dependency checksums. |
| deployment/tests/go.mod | Defines the deployment-test module. |
| deployment/tests/fixtures/instant-bosh-cf.yml | Models consolidated CF groups. |
| deployment/tests/fixtures/cf-deployment.yml | Models standard CF groups. |
| deployment/runtime-configs/README.md | Explains standard and compatibility configurations. |
| deployment/runtime-configs/operations/use-azure-managed-identities.yml | Clarifies the BPM requirement in a comment. |
| deployment/runtime-configs/juicefs-volume-driver.yml | Targets diego-cell by default. |
| deployment/runtime-configs/instant-bosh/juicefs-volume-driver.yml | Adds the compute compatibility configuration. |
| deployment/operations/cf/non-ha-validation.yml | Clarifies DNS alias scope in comments. |
| deployment/operations/cf/instant-bosh/enable-volume-services.yml | Enables volume services on control. |
| deployment/operations/cf/instant-bosh/acceptance-errand-vm.yml | Overrides the errand VM type to default. |
| deployment/operations/cf/enable-volume-services.yml | Targets standard Cloud Controller groups. |
| deployment/operations/cf/enable-juicefs-acceptance-tests.yml | Defaults the errand VM type to minimal. |
| AGENTS.md | Updates development and topology guidance. |
| .github/workflows/acceptance.yml | Adds deployment validation and dependency-cache input. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
The full acceptance workflow will run on this PR.