Skip to content

Fix search box and search past the 10k scan cap - #96

Merged
cloudlena merged 1 commit into
cloudlena:mainfrom
kumarkshitij171:main
Oct 15, 2026
Merged

cloudlena merged 1 commit into
cloudlena:mainfrom
kumarkshitij171:main

Conversation

@kumarkshitij171

@kumarkshitij171 kumarkshitij171 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #97

Summary

  • When a listing hits the 10,000-object cap, a search also asks S3 for keys
    starting with the term, so those are found however far into the prefix
    they are. Matches in the middle of a key still cover the first 10,000.
  • Make the clear (X) icon clickable and show a "Searching…" state on the
    Search button.
  • Set color-scheme to match the BeerCSS mode so autofilled text and native
    controls are readable in dark mode.

Test plan

  • make test, with new tests for prefix search past the cap and for no
    extra listing on small prefixes
  • Checked the clear icon and the dark-mode text color in Chrome
  • Search a bucket with more than 10,000 objects for a key past the cap

- Find keys beyond the first 10,000 objects by also listing by prefix
- Make the clear (X) icon clickable and show a searching state
- Match color-scheme to the theme so autofilled text is readable in dark mode
@cloudlena
cloudlena merged commit 065a72c into cloudlena:main Oct 15, 2026
1 check passed
@cloudlena

Copy link
Copy Markdown
Owner

Thanks, @kumarkshitij171!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search misses objects past the first 10,000 and the search box has UI issues

2 participants