Repository navigation
docs: clarify user guide wording and accuracy - #669
Open
gustabowill wants to merge 1 commit into
Open
gustabowill wants to merge 1 commit into
gustabowill wants to merge 1 commit into
Conversation
Signed-off-by: Gustavo William <gustavo.oliveira@enterprisedb.com>
gustabowill
force-pushed
the
docs/user-guide-fixes
branch
from
November 19, 2026 12:55
5da630a to
725c3f7
Compare
gustabowill
commented
Nov 19, 2026
Comment on lines
-351
to
+352
| Create a corresponding `PluginConfiguration` that specifies which backup to | ||
| restore: | ||
| Create a corresponding `PluginConfiguration` that tells Klio how to reach the server | ||
| holding the backups: |
Contributor
Author
There was a problem hiding this comment.
IIUC the Cluster is what has the backupID field, not the PluginConfiguration.
gustabowill
commented
Nov 19, 2026
| hour (check with `pg_stat_archiver` or monitor WAL production) | ||
| hour. Estimate it by sampling `pg_current_wal_lsn()` at two points in | ||
| time, computing the difference with `pg_wal_lsn_diff()`, then dividing by | ||
| `wal_segment_size`, scaling the results to one hour. |
Contributor
Author
There was a problem hiding this comment.
I first thought "Klio does not use archiving, so pg_stat_archiver should not help", then I noticed the CNPG instance still has an archive_command even though using Klio. Nonetheless I still think this describes a better way to measure WAL volume?
gustabowill
marked this pull request as ready for review
November 19, 2026 15:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes I made while going through the Klio docs: wording tweaks and a few clarifications in the user guide.