Repository navigation
Conversation
The sidecar env was built from the postgres container env first, and the defaults and `instanceSidecarConfiguration.env` were added only for names not already there. A variable the instance already defines, such as `TMPDIR` or `PGHOST`, could not be changed for the sidecar. Merge the configured env first, then the main container env and the defaults, so the explicit configuration takes precedence. Closes cloudnative-pg#1250 Signed-off-by: AdzerKI <silver_cat@list.ru>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reconcilePodSpeccopied the postgres container env into the sidecar first and addedinstanceSidecarConfiguration.envonly for names not already present, so a variable the instance defines (TMPDIR,PGHOST, ...) could not be set for the sidecar.The configured env is now merged first, then the main container env, then the defaults. The "append if the name is missing" loop, needed a third time now, moves into
appendMissingEnvs.Closes #1250