Skip to content

fix(service) Ordering#1163

Draft
tsim-sap wants to merge 1 commit intomainfrom
tsim-sap/issue-1154/fix-service-ordering
Draft

fix(service) Ordering#1163
tsim-sap wants to merge 1 commit intomainfrom
tsim-sap/issue-1154/fix-service-ordering

Conversation

@tsim-sap
Copy link
Copy Markdown
Collaborator

@tsim-sap tsim-sap commented Apr 10, 2026

Description

This PR fixes the ordering for service list.

Current state sorts by ID, changed that to use vulnerability count for ordering.

  • 🐛 Bug Fix

Related Tickets & Documents

Fixes #1154

Added tests?

  • 👍 yes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tsim-sap tsim-sap force-pushed the tsim-sap/issue-1154/fix-service-ordering branch 2 times, most recently from 81f668c to 7a6da5b Compare April 10, 2026 11:26
michalkrzyz
michalkrzyz reviewed Apr 11, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@michalkrzyz michalkrzyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add or adjust the test to show the problem?

@tsim-sap tsim-sap force-pushed the tsim-sap/issue-1154/fix-service-ordering branch from 7a6da5b to 2fd0b0b Compare April 13, 2026 11:44
@tsim-sap
Copy link
Copy Markdown
Collaborator Author

tsim-sap commented Apr 13, 2026

is it possible to add or adjust the test to show the problem?

yep, working on it

@tsim-sap tsim-sap force-pushed the tsim-sap/issue-1154/fix-service-ordering branch from 2fd0b0b to 7d60ee3 Compare April 13, 2026 14:52
@tsim-sap tsim-sap force-pushed the tsim-sap/issue-1154/fix-service-ordering branch from 7d60ee3 to 912a4de Compare April 13, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalkrzyz michalkrzyz michalkrzyz left review comments

@drochow drochow Awaiting requested review from drochow drochow will be requested when the pull request is marked ready for review drochow is a code owner

@MR2011 MR2011 Awaiting requested review from MR2011 MR2011 will be requested when the pull request is marked ready for review MR2011 is a code owner

@dorneanu dorneanu Awaiting requested review from dorneanu dorneanu will be requested when the pull request is marked ready for review dorneanu is a code owner

@copyonwrite copyonwrite Awaiting requested review from copyonwrite copyonwrite will be requested when the pull request is marked ready for review copyonwrite is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(service): ordering

2 participants

@tsim-sap @michalkrzyz