Skip to content

EvictionController: Fix unused logger context return value #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notandy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

EvictionController: Fix unused logger context return value #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/controller/eviction_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ func (r *EvictionReconciler) evictNext(ctx context.Context, eviction *kvmv1.Evic
instances := &eviction.Status.OutstandingInstances
uuid := (*instances)[len(*instances)-1]
log := logger.FromContext(ctx).WithName("Evict").WithValues("server", uuid)
logger.IntoContext(ctx, log)
ctx = logger.IntoContext(ctx, log)

res := servers.Get(ctx, r.computeClient, uuid)
vm, err := res.Extract()
Expand All @@ -255,7 +255,7 @@ func (r *EvictionReconciler) evictNext(ctx context.Context, eviction *kvmv1.Evic
}

log = log.WithValues("server_status", vm.Status)
logger.IntoContext(ctx, log)
ctx = logger.IntoContext(ctx, log)

// First, check the transient statuses
switch vm.Status {
Expand Down
Loading