Security: pin GitHub Actions to SHA hashes #257
+15
−15
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,7 +18,7 @@ jobs: | |||||
| - name: Jira Login | ||||||
| if: env.JIRA_CREATE_ISSUE_AUTO == 'true' | ||||||
| id: login | ||||||
| uses: atlassian/gajira-login@90a599561baaf8c05b080645ed73db7391c246ed # v2.0.0 | ||||||
| env: | ||||||
| JIRA_BASE_URL: ${{ secrets.JIRA_BASE_URL }} | ||||||
| JIRA_USER_EMAIL: ${{ secrets.JIRA_USER_EMAIL }} | ||||||
|
|
@@ -27,7 +27,7 @@ jobs: | |||||
| - name: Jira Create issue | ||||||
| if: env.JIRA_CREATE_ISSUE_AUTO == 'true' | ||||||
| id: create_jira_issue | ||||||
| uses: atlassian/gajira-create@c0a9c69ac9d6aa063fed57201e55336ada860183 # v2.0.1 | ||||||
| with: | ||||||
| project: ${{ secrets.JIRA_PROJECT }} | ||||||
| issuetype: ${{ secrets.JIRA_ISSUE_TYPE }} | ||||||
|
|
@@ -53,7 +53,7 @@ jobs: | |||||
|
|
||||||
| - name: Update GitHub issue | ||||||
| if: env.JIRA_CREATE_ISSUE_AUTO == 'true' | ||||||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||||||
|
There was a problem hiding this comment. 🟡 MEDIUM RISK The SHA hash corresponds to v3.0.0 but is labeled as v2.0.0. Use the correct hash for v2.0.0 to maintain consistency.
Suggested change
|
||||||
| env: | ||||||
| JIRA_ISSUE_NUMBER: ${{ steps.create_jira_issue.outputs.issue }} | ||||||
| GITHUB_ORIGINAL_TITLE: ${{ github.event.issue.title }} | ||||||
|
|
@@ -78,7 +78,7 @@ jobs: | |||||
|
|
||||||
| - name: Add comment after sync | ||||||
| if: env.JIRA_CREATE_ISSUE_AUTO == 'true' | ||||||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||||||
|
There was a problem hiding this comment. 🟡 MEDIUM RISK The SHA hash corresponds to v3.0.0 but is labeled as v2.0.0. Use the correct hash for v2.0.0 to maintain consistency.
Suggested change
|
||||||
| with: | ||||||
| github-token: ${{secrets.GITHUB_TOKEN}} | ||||||
| script: | | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,7 +18,7 @@ jobs: | |||||
| - name: Jira Login | ||||||
| if: github.event.label.name == env.JIRA_ISSUE_LABEL | ||||||
| id: login | ||||||
| uses: atlassian/gajira-login@90a599561baaf8c05b080645ed73db7391c246ed # v2.0.0 | ||||||
| env: | ||||||
| JIRA_BASE_URL: ${{ secrets.JIRA_BASE_URL }} | ||||||
| JIRA_USER_EMAIL: ${{ secrets.JIRA_USER_EMAIL }} | ||||||
|
|
@@ -27,7 +27,7 @@ jobs: | |||||
| - name: Jira Create issue | ||||||
| if: github.event.label.name == env.JIRA_ISSUE_LABEL | ||||||
| id: create_jira_issue | ||||||
| uses: atlassian/gajira-create@c0a9c69ac9d6aa063fed57201e55336ada860183 # v2.0.1 | ||||||
| with: | ||||||
| project: ${{ secrets.JIRA_PROJECT }} | ||||||
| issuetype: ${{ secrets.JIRA_ISSUE_TYPE }} | ||||||
|
|
@@ -53,7 +53,7 @@ jobs: | |||||
|
|
||||||
| - name: Change Title | ||||||
| if: github.event.label.name == env.JIRA_ISSUE_LABEL | ||||||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||||||
|
There was a problem hiding this comment. 🟡 MEDIUM RISK The SHA hash corresponds to v3.0.0 but is labeled as v2.0.0. Use the correct hash for v2.0.0 to maintain consistency.
Suggested change
|
||||||
| env: | ||||||
| JIRA_ISSUE_NUMBER: ${{ steps.create_jira_issue.outputs.issue }} | ||||||
| GITHUB_ORIGINAL_TITLE: ${{ github.event.issue.title }} | ||||||
|
|
@@ -70,7 +70,7 @@ jobs: | |||||
|
|
||||||
| - name: Add comment after sync | ||||||
| if: github.event.label.name == env.JIRA_ISSUE_LABEL | ||||||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||||||
|
There was a problem hiding this comment. 🟡 MEDIUM RISK The SHA hash corresponds to v3.0.0 but is labeled as v2.0.0. Use the correct hash for v2.0.0 to maintain consistency.
Suggested change
|
||||||
| with: | ||||||
| github-token: ${{secrets.GITHUB_TOKEN}} | ||||||
| script: | | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 HIGH RISK
This workflow uses
pull_request_targetand checks out the pull request's head code viaref: ${{ github.event.pull_request.head.sha }}. This allows potentially untrusted code from the pull request to run with access to repository secrets. Even with the check fordependabot[bot], this pattern is discouraged. For dependabot auto-merging, consider using thepull_requestevent or avoiding the checkout of the head ref in a privileged context.Try running the following prompt in your IDE agent: