Repository navigation
fix(s3vectors): restore query pagination - #352
Open
Lawliet2004 wants to merge 3 commits into
Open
Lawliet2004 wants to merge 3 commits into
Lawliet2004 wants to merge 3 commits into
Conversation
Kaap10
requested changes
Nov 8, 2026
Kaap10
left a comment
Kaap10
left a comment
Collaborator
There was a problem hiding this comment.
The query_vectors pagination and nextToken casing fix is solid and passes all tests.
However, please remove the unrelated dated issue audit document from the PR (see inline comment) so this PR remains a focused bugfix.
| @@ -0,0 +1,165 @@ | |||
| # Issue audit — 6 November 2026 | |||
Collaborator
There was a problem hiding this comment.
Please remove this file from the PR. While this issue audit is valuable and well-researched, committing a dated, point-in-time triage report into the permanent repository documentation (docs/) will quickly become stale and pollutes user-facing documentation. Please move this analysis to a GitHub Discussion or tracking issue instead.
Contributor
Author
Lawliet2004
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
S3 Vectors queries raise
OperationNotPageableErroron the boto3 and aioboto3 versions installed bymake install. On SDK versions that support continuation, readingNextTokeninstead of the API'snextTokenstops the query after the first response.Changes
query_vectorsdirectly in the sync and async stores and forwardnextTokenuntil the results reach top-k or the service has no more pages. This preserves stream chunking, rate limiting, and error translation.Older SDKs without continuation fields still support a single response. The dependency constraints are unchanged. AWS QueryVectors API · boto3 query_vectors
Related issues
This is a regression follow-up to #16. The November 6 audit is tracked separately in #353.
Testing
make run-cion Python 3.12.15 passed Ruff, strict mypy, and pytest with 1,125 tests passed, 2 opt-in live AWS tests skipped, and 1 snapshot passed.git diff --checkpassed.