Repository navigation
fix(deps): clear the moderate dev-dependency advisories that Dependabot cannot fix - #347
Conversation
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
…release younger than Dependabot's cooldown
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Review record for the merge decision.
Generated with |
Why
#176 moved the repo to pnpm so that Dependabot can update dependencies. On its first run on main, Dependabot's security jobs for
@vitest/mocker,brace-expansion,minimatchandpostcssall failed withsecurity_update_not_possible. A pin held each package:vitestis pinned exactly and pulls@vitest/mocker4.1.11.postcssandbrace-expansionare pinned exactly inpnpm.overrides. With an exact override,pnpm update postcss@8.5.32 --lockfile-onlyexits 0 but leaves 8.5.18 in the lock.minimatch10 andglob13 come from dependencies whose ranges exclude the fixed majors.All of these are dev dependencies. None of them ships in the npm package.
What changed
@vitest/mocker< 4.1.12vitest4.1.11 → 4.1.12postcss<= 8.5.22^8.5.32brace-expansion< 5.0.12^5.0.12glob<= 14.0.1rimraf, the only package that pulledglobminimatch< 11.0.1^11.0.3cleanscript (fixed in fix: make npm run clean remove the build info files #348) now runsnode -ewithfs.rmSync(..., { recursive: true, force: true })on the same four paths. The script uses only single quotes inside its double-quoted argument, so it works inshand incmd.exe. Theclean-script.test.tstest from fix: make npm run clean remove the build info files #348 still passes against it.pnpm.overridesentry is now^<version>instead of an exact version. The lock keeps the same resolved versions for the entries this PR does not bump. With^8.5.18,pnpm update postcss@8.5.32 --lockfile-only --no-save -rmoved the lock to 8.5.32, while the exact override left it at 8.5.18. This helps Dependabot only forpostcssandnanoid, which sit undervite's re-resolved subtree. Forminimatchandbrace-expansion, Dependabot's command leaves the lock unchanged even with a caret floor, so a future advisory on them still needs a manual bump, as before this PR.minimatchoverride. release-please's@google-automations/git-file-utilsstill asks forminimatch^10.2.4, also in its latest release, and every 10.x is vulnerable. git-file-utils uses onlynew Minimatch(glob).match(path), which works the same with the CommonJS build of 11.x. An earlier verifier ranfindFilesByGlobwith 34 patterns and got the same results on 10.2.5 and 11.x.tslib2.9.1 → 2.8.1 and@napi-rs/wasm-runtime1.2.7 → 1.2.6 (main had releases younger than 7 days; both sit only under rolldown's wasm32 binding).tinyglobby0.2.15 andpicomatch4.0.4 drop out because vitest 4.1.12 uses newer ones.minimatch11 adds@isaacs/nonrecursive-glob-match, andlru-cache11 leaves withglob. The production dependency closure is unchanged.--config.minimum-release-age=10080.minimatchresolves to 11.0.3 (11.0.4 is 3 days old), and dropping rimraf removesrimraf@6.1.4(2 days old).BEGIN_COMMIT_OVERRIDE
fix(deps): clear the moderate dev-dependency advisories that Dependabot cannot fix
END_COMMIT_OVERRIDE
Validation
pnpm audit: "No known vulnerabilities found" (main: 6 moderate)..agents/skills/verify-agent-tty/scripts/dependabot-resolve.sh(empty-store replay of Dependabot's resolve, from fix(deps): unblock Dependabot's pnpm resolve (release age and trust checks) #346): 3 of 3 resolved.pnpm install --frozen-lockfile, thenmise run --forceofformat-check,workflow-lint,lint,audit,typecheck,clean,build,test-unit(146 files, 2137 tests),install-smokeandvalidate-bundles: exit 0. Afterclean,dist/and both build info files are gone, andbuildwritesdist/cli/main.js.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high