Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9734195de4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $lowerName = strtolower($productName); | ||
| $product = $productMap[$lowerName] ?? null; |
There was a problem hiding this comment.
Using a lowercased key for lookup means two import groups like "Widget" and "widget" now resolve to the same $productMap entry, so on case-sensitive databases (such as SQLite/PostgreSQL) the second group can be attached to the first product instead of creating/finding its own product. This changes import semantics and can silently place variants under the wrong product name.
Useful? React with 👍 / 👎.
| DB::transaction(function () use ($groupedData, &$count) { | ||
| // Optimization: Pre-fetch products to avoid N+1 queries | ||
| $productNames = $groupedData->keys(); | ||
| $existingProducts = Product::whereIn('name', $productNames)->get(); |
There was a problem hiding this comment.
Prefetching with a single whereIn('name', $productNames) binds one parameter per unique imported product name, so large imports can exceed parameter limits on some supported drivers (for example SQL Server) and fail the whole transaction. The previous per-name lookup avoided this single-statement limit, so this optimization needs chunking to remain safe at higher import sizes.
Useful? React with 👍 / 👎.
1 participant
whereIn.tests/Feature/ProductImportPerformanceTest.php.PR created automatically by Jules for task 13802936237308428942 started by @sayuru-akash