Fix pressing "Enter" in the "add link" modal submitting the parent form#2024
Merged
ArtOfCode- merged 1 commit intodevelopfrom Mar 20, 2026
Merged
Fix pressing "Enter" in the "add link" modal submitting the parent form#2024ArtOfCode- merged 1 commit intodevelopfrom
ArtOfCode- merged 1 commit intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cellio
approved these changes
Mar 17, 2026
Member
cellio
left a comment
There was a problem hiding this comment.
Works now -- pressing enter in either field (anchor text or link) does nothing, so you have to click the "insert" button to return to the editor. No premature post submissions.
ArtOfCode-
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2023
This is a "quick and dirty" version of the fix as I don't have full access to my usual tools at the moment (a proper fix would be moving the modal outside the
markdown_toolspartial asformtags can't be nested, wrapping the inputs in a<form>tag, and cancelling [preventDefault] anysubmitevent on it - see theimage_uploadpartial for how it should be done). Nevertheless, it should do the trick.