contractual next version

.eslintrc

@@ -62,8 +62,7 @@
       {
         "devDependencies": true,
         "optionalDependencies": false,
-        "peerDependencies": false,
-        "packageDir": "./"
+        "peerDependencies": false
       }
     ],
     "@typescript-eslint/consistent-type-imports": [
@@ -72,6 +71,13 @@
         "prefer": "type-imports",
         "disallowTypeAnnotations": false
       }
+    ],
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      {
+        "argsIgnorePattern": "^_",
+        "varsIgnorePattern": "^_"
+      }
     ]
   },
   "env": {

.github/dependabot.yml

@@ -0,0 +1,28 @@
+version: 2
+updates:
+  - package-ecosystem: npm
+    directory: /
+    # The default branch is next. Omit target-branch so security groups apply too.
+    schedule:
+      interval: weekly
+      day: monday
+    open-pull-requests-limit: 5
+    commit-message:
+      prefix: "fix(*)"
+    groups:
+      security:
+        applies-to: security-updates
+        patterns: ["*"]
+      development:
+        dependency-type: development
+        update-types: [minor, patch]
+    versioning-strategy: increase
+  - package-ecosystem: github-actions
+    directory: /
+    schedule:
+      interval: weekly
+    commit-message:
+      prefix: ci
+    groups:
+      actions:
+        patterns: ["*"]

.github/pull_request_template.md

@@ -0,0 +1,11 @@
+## Change
+
+Describe the problem and resulting behavior. Target `next` and use a Conventional Commit title, for example `fix(cli): handle missing snapshots`.
+
+## Validation
+
+List the relevant checks and their results.
+
+## Release impact
+
+Describe any compatibility change. Tagging or publishing requires Omer's explicit approval; a PR is not release approval.

.github/workflows/ci.yml

@@ -1,126 +1,43 @@
 name: Continuous Integration
-on: [pull_request]
-
+on:
+  pull_request:
+    branches: [next]
+  push:
+    branches: [next]
 permissions:
-  id-token: write
   contents: read
-  checks: write
-
+concurrency:
+  group: ci-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
 jobs:
-  build:
-    name: Build
+  verify:
+    name: Verify (Node ${{ matrix.node }})
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
-        node-version: [18.x, 20.x, 22.x]
+        node: [22, 24, 26]
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-
-      - name: Use Node ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
-        with:
-          node-version: ${{ matrix.node-version }}
-      - name: Install pnpm
-        uses: pnpm/action-setup@v4
+      - uses: actions/checkout@v7
+      - uses: pnpm/action-setup@v6
         with:
           version: 9.15.4
-      - uses: actions/cache@v2
-        with:
-          path: '**/node_modules'
-          key: ${{ runner.os }}-modules-${{ hashFiles('**/pnpm-lock.yaml') }}
-
-      - name: PNPM
-        run: pnpm install --frozen-lockfile
-
-      - name: Build
-        run: pnpm run build
-
-  lint:
-    name: Lint
+      - uses: actions/setup-node@v7
+        with:
+          node-version: ${{ matrix.node }}
+          cache: pnpm
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm build
+      - run: pnpm lint
+      - run: pnpm test
+      - run: pnpm test:e2e
+  ci:
+    name: CI
+    if: always()
+    needs: [verify]
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Setup Node
-        uses: actions/setup-node@v4
-        with:
-          node-version: '22.x'
-      - name: Install pnpm
-        uses: pnpm/action-setup@v4
-        with:
-          version: 9.15.4
-
-      - uses: actions/cache@v2
-        with:
-          path: '**/node_modules'
-          key: ${{ runner.os }}-modules-${{ hashFiles('**/pnpm-lock.yaml') }}
-
-      - name: PNPM
-        run: pnpm install --frozen-lockfile
-
-      - name: Lint
-        run: pnpm run lint
-
-      - name: Validate Packages
-        run: pnpm manypkg check
-
-  test:
-    name: Test
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        project: ['doubles.jest', 'doubles.sinon', 'core.unit', 'doubles.vitest', 'di.nestjs', 'di.inversify', 'unit']
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Setup Node
-        uses: actions/setup-node@v4
-        with:
-          node-version: '22.x'
-      - name: Install pnpm
-        uses: pnpm/action-setup@v4
-        with:
-          version: 9.15.4
-
-      - uses: actions/cache@v2
-        with:
-          path: '**/node_modules'
-          key: ${{ runner.os }}-modules-${{ hashFiles('**/pnpm-lock.yaml') }}
-
-      - name: PNPM
-        run: pnpm install --frozen-lockfile
-
-      - name: Create Coverage Directory
-        run: mkdir -p ${{ github.workspace }}/coverage
-
-      - name: Test
-        run: pnpm --filter @contractual/${{ matrix.project }} run test
+      - name: Require every verification job
         env:
-          JEST_JUNIT_OUTPUT_NAME: ${{ matrix.project }}.xml
-          JEST_JUNIT_OUTPUT_DIR: ${{ github.workspace }}/test-reports
-          JUNIT_OUTPUT_NAME: ${{ matrix.project }}
-          JUNIT_OUTPUT_DIR: ${{ github.workspace }}/test-reports
-          COVERAGE_DIR: ${{ github.workspace }}/coverage
-          COVERAGE_FILE: coverage-${{ matrix.project }}.xml
-
-      - name: Tests Results
-        uses: dorny/test-reporter@v1
-        if: always()
-        with:
-          reporter: 'jest-junit'
-          name: Tests Results (${{ matrix.project }})
-          path: ${{ github.workspace }}/test-reports/${{ matrix.project }}.xml
-          fail-on-error: false
-
-#      - name: Upload Report to Codecov
-#        uses: codecov/codecov-action@v3
-#        with:
-#          name: codecov-umbrella
-#          flags: ${{ matrix.project }}
-#          token: ${{ secrets.CODECOV_TOKEN }}
-#          fail_ci_if_error: true
-#          files: ${{ github.workspace }}/coverage/coverage-${{ matrix.project }}.xml
-#          verbose: true
+          RESULT: ${{ needs.verify.result }}
+        run: test "$RESULT" = success

.github/workflows/e2e-release.yml

@@ -0,0 +1,158 @@
+name: E2E Release Simulation
+env:
+  CI: true
+
+on:
+  workflow_call:
+    inputs:
+      target_branch:
+        description: 'Branch to test release from'
+        required: true
+        type: string
+  workflow_dispatch:
+    inputs:
+      target_branch:
+        description: 'Branch to test release from'
+        required: true
+        type: string
+        default: 'next'
+
+permissions:
+  contents: read
+
+jobs:
+  e2e:
+    if: github.ref == 'refs/heads/next'
+    name: E2E (${{ matrix.e2e-project }}, Node ${{ matrix.node-version }})
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        e2e-project: ['cli-basic', 'cli-lifecycle', 'packages-import']
+        node-version: [22.x, 24.x, 26.x]
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v7
+        with:
+          ref: next
+          fetch-depth: 0
+
+      - name: Setup Node ${{ matrix.node-version }}
+        uses: actions/setup-node@v7
+        with:
+          node-version: ${{ matrix.node-version }}
+
+      - name: Install pnpm
+        uses: pnpm/action-setup@v6
+        with:
+          version: 9.15.4
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Start Verdaccio
+        run: docker compose -f local-e2e.docker-compose.yaml up -d verdaccio
+
+      - name: Wait for Verdaccio
+        run: |
+          for i in {1..30}; do
+            if curl -s http://localhost:4873 > /dev/null; then
+              echo "Verdaccio is ready"
+              break
+            fi
+            echo "Waiting for Verdaccio..."
+            sleep 1
+          done
+
+      - name: Build
+        run: pnpm build
+
+      - name: Setup Registry
+        uses: actions/setup-node@v7
+        with:
+          node-version: ${{ matrix.node-version }}
+          registry-url: http://localhost:4873
+          scope: '@contractual'
+          always-auth: false
+
+      - name: Install jq
+        run: sudo apt-get install -y jq
+
+      - name: Config Git
+        run: |
+          git config --global user.email "e2e@contractual.dev"
+          git config --global user.name "Contractual e2e"
+
+      - name: Remove provenance from package.json files
+        run: |
+          find packages -name 'package.json' | while read filename; do
+            jq 'del(.publishConfig.provenance)' "$filename" > temp.json && mv temp.json "$filename"
+          done
+
+      - name: Commit Provenance Removal
+        run: |
+          git add .
+          git commit -am "chore: remove provenance for e2e"
+
+      - name: Version Packages
+        run: |
+          BRANCH_NAME=$(git rev-parse --abbrev-ref HEAD)
+          npx lerna version --yes \
+          --conventional-commits \
+          --conventional-prerelease \
+          --preid e2e \
+          --no-changelog \
+          --allow-branch "$BRANCH_NAME" \
+          --no-git-tag-version \
+          --no-push \
+          --force-publish \
+          --no-commit-hooks
+
+      - name: Commit Packages Versions
+        run: |
+          git add .
+          git commit -am "bump versions"
+
+      - name: Capture Versions for Report
+        run: |
+          echo "## E2E Test Results" >> $GITHUB_STEP_SUMMARY
+          echo "" >> $GITHUB_STEP_SUMMARY
+          echo "**Project:** \`${{ matrix.e2e-project }}\`" >> $GITHUB_STEP_SUMMARY
+          echo "**Node:** \`${{ matrix.node-version }}\`" >> $GITHUB_STEP_SUMMARY
+          echo "" >> $GITHUB_STEP_SUMMARY
+          echo "### Versions:" >> $GITHUB_STEP_SUMMARY
+          lerna ls --json | jq -r '.[] | "- **\(.name)** -> `v\(.version)`"' >> $GITHUB_STEP_SUMMARY
+
+      - name: Publish Packages to Verdaccio
+        run: |
+          npx lerna publish from-package --yes \
+          --no-git-tag-version \
+          --no-push \
+          --no-git-reset \
+          --exact \
+          --dist-tag e2e
+
+      - name: Clean Source (simulate fresh install)
+        run: |
+          rm -rf packages
+          rm -rf node_modules
+          rm pnpm-lock.yaml
+          rm package.json
+          rm -f .npmrc
+
+      - name: Install E2E Dependencies from Verdaccio
+        run: |
+          cd "${{ github.workspace }}/e2e/${{ matrix.e2e-project }}"
+          npm install --registry http://localhost:4873 --no-package-lock
+
+      - name: Execute Tests
+        run: |
+          cd "${{ github.workspace }}/e2e/${{ matrix.e2e-project }}"
+          npm test
+
+      - name: Test Success Summary
+        if: success()
+        run: |
+          echo "" >> $GITHUB_STEP_SUMMARY
+          echo "### Test Passed" >> $GITHUB_STEP_SUMMARY
+          echo "Packages work correctly when published" >> $GITHUB_STEP_SUMMARY