update SmoothScroll render function to loop only when user is scrolling#4
Open
annafractuous wants to merge 1 commit intocodrops:masterfrom
Open
update SmoothScroll render function to loop only when user is scrolling#4annafractuous wants to merge 1 commit intocodrops:masterfrom
annafractuous wants to merge 1 commit intocodrops:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using a console.log statement in the SmoothScroll render() function that outputs the timestamp (hh:mm:ss) and the current value of scrollingSpeed to illustrate the difference in how often the function runs:
before (runs 60x per second, even before the user has started scrolling):
after (runs only while the user is scrolling; stops when they stop scrolling and starts again when they scroll again):
