Repository navigation
Vendor the nine shipped Opik skills from opik-mcp; retire agent-ops #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: skills-drift | ||
|
|
||
| # Fails if the vendored skills under skills/ have drifted from their source of truth | ||
| # (comet-ml/opik-mcp at the CANON_REF pinned in scripts/sync-shared-skills.sh). | ||
| # Fix: edit upstream, merge, bump CANON_REF, re-run the script, commit. | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: ["skills/**", "scripts/sync-shared-skills.sh", ".github/workflows/skills-drift.yml"] | ||
| push: | ||
| branches: [main] | ||
|
|
||
| jobs: | ||
| drift: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - name: Re-vendor at the pinned ref and check for drift | ||
| run: | | ||
| bash scripts/sync-shared-skills.sh | ||
| if ! git diff --quiet -- skills || [ -n "$(git status --porcelain -- skills)" ]; then | ||
| echo "::error::Vendored skills differ from comet-ml/opik-mcp at the pinned CANON_REF." | ||
| git --no-pager status --porcelain -- skills | ||
| exit 1 | ||
| fi | ||
| echo "no drift" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| #!/usr/bin/env bash | ||
| # Vendor the shared Opik skills from their source of truth (OPIK-7471). | ||
| # | ||
| # The skills under skills/ are OWNED by comet-ml/opik-mcp (src/opik_mcp/skills) and | ||
| # published from there as the opik-skills pack. Do not hand-edit them here — edit the | ||
| # source, get it merged, then bump CANON_REF and re-run this script. The drift check | ||
| # in .github/workflows/skills-drift.yml fails a pull request whose vendored copy | ||
| # differs from the pinned source. | ||
| # | ||
| # Usage: bash scripts/sync-shared-skills.sh # at the pinned ref | ||
| # CANON_REF=<commit-or-tag> bash scripts/sync-shared-skills.sh | ||
| set -euo pipefail | ||
|
|
||
| CANON_REPO="${CANON_REPO:-https://github.com/comet-ml/opik-mcp.git}" | ||
| CANON_REF="${CANON_REF:-0baa5aecf0224701473efd968be4aa5a166ba99f}" # opik-mcp main after #191 (nine skills) | ||
| SRC="src/opik_mcp/skills" | ||
| DEST="skills" | ||
| # Every skill the pack ships. Order matches the published index. | ||
| SHARED=(opik opik-compare opik-diagnose opik-evaluate opik-explain opik-instrument opik-online-eval opik-optimize opik-test) | ||
|
|
||
| tmp="$(mktemp -d)" | ||
| trap 'rm -rf "$tmp"' EXIT | ||
| git clone --quiet --filter=blob:none "$CANON_REPO" "$tmp" # blobs fetched lazily on checkout | ||
| git -C "$tmp" checkout --quiet "$CANON_REF" | ||
|
|
||
| for s in "${SHARED[@]}"; do | ||
| if [ ! -d "$tmp/$SRC/$s" ]; then | ||
| # SHARED and CANON_REF disagree. Carrying on would leave the stale vendored copy in | ||
| # place and the drift check would pass over it, so this is an error, not a warning. | ||
| echo "error: '$s' is in SHARED but not in opik-mcp@$CANON_REF — drop it from SHARED or bump the pin" >&2 | ||
| exit 1 | ||
| fi | ||
| rm -rf "${DEST:?}/$s" | ||
| # Same exclusions as the published pack: evals/ is development tooling. | ||
| rsync -a --exclude evals --exclude __pycache__ "$tmp/$SRC/$s/" "$DEST/$s/" | ||
| echo "synced $s" | ||
| done | ||
| echo "Done. Vendored ${#SHARED[@]} skills from opik-mcp@$CANON_REF" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # These skills are vendored — do not hand-edit them | ||
|
|
||
| Everything under `skills/` is **vendored from the source of truth**, | ||
| [`comet-ml/opik-mcp`](https://github.com/comet-ml/opik-mcp) (`src/opik_mcp/skills`, | ||
| OPIK-7471) — the same files published as the `opik-skills` pack. Edit them there, get | ||
| the change merged, then bump `CANON_REF` in `scripts/sync-shared-skills.sh` and re-run: | ||
|
|
||
| ```bash | ||
| bash scripts/sync-shared-skills.sh | ||
| ``` | ||
|
|
||
| `.github/workflows/skills-drift.yml` fails a pull request whose vendored copy differs | ||
| from the pinned source. This repo still owns everything else: `commands/`, `agents/`, | ||
| `hooks/`, and the session logger. |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.