Skip to content

ci: delete the hand-vendored workflow file - #16

Merged
tyrsson merged 1 commit into
1.0.xfrom
tyrsson-remove-vendored-workflow
Nov 13, 2026
Merged

tyrsson merged 1 commit into
1.0.xfrom
tyrsson-remove-vendored-workflow

Conversation

@tyrsson

@tyrsson tyrsson commented Nov 13, 2026

Copy link
Copy Markdown
Member

What this removes

.github/workflows/continuous-integration.yml, the hand-vendored copy of the webinertia/.github workflow. It existed only because the common-doc organization had no .github repository to host the real one.

That copy was maintained by hand, named the wrong owner in its header, and added a push: branches: [1.0.x] trigger so it could run for this repository alone. The trigger has no meaning for a workflow hosted in another repository, so with the organization workflow now required it would only produce a second, duplicate run.

Nothing else is touched.

Why now

The owner created common-doc/.github (repository id 1456043346, default branch master) and organization ruleset 27171943, which applies to 1.0.x here with four rules: deletion, non_fast_forward, pull_request and workflows. The workflows rule requires .github/workflows/continuous-integration.yml at refs/heads/master in repository 1456043346.

Pre-state, recorded before the deletion:

  • Every check on the merged stack came from the vendored file. For example run 43347788026 reports "head_repository":"common-doc/commondoc" and "path":".github/workflows/continuous-integration.yml", so the source was this repository, not the organization.
  • The organization workflow is present in common-doc/.github at the required path, size 25028 bytes, so the required context has somewhere to come from.

What to watch

The required check must arrive from the organization run and be named Continuous Integration. If it does not, this pull request is the finding: the deletion is then unsafe, and the answer is not a shim or a second workflow.

No merge is requested here.

The organization now hosts the CI workflow in common-doc/.github and runs it
through ruleset 27171943, which requires
.github/workflows/continuous-integration.yml at refs/heads/master in that
repository. A copy in this repository is no longer the source of truth: it
also carries a push trigger that only ever meant anything while the workflow
lived here, so a push would run it alongside the required run.

Delete the copy and nothing else.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@tyrsson
tyrsson merged commit 184f7e5 into 1.0.x Nov 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant