Repository navigation
ci: delete the hand-vendored workflow file - #16
Merged
Merged
Conversation
The organization now hosts the CI workflow in common-doc/.github and runs it through ruleset 27171943, which requires .github/workflows/continuous-integration.yml at refs/heads/master in that repository. A copy in this repository is no longer the source of truth: it also carries a push trigger that only ever meant anything while the workflow lived here, so a push would run it alongside the required run. Delete the copy and nothing else. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this removes
.github/workflows/continuous-integration.yml, the hand-vendored copy of thewebinertia/.githubworkflow. It existed only because the common-doc organization had no.githubrepository to host the real one.That copy was maintained by hand, named the wrong owner in its header, and added a
push: branches: [1.0.x]trigger so it could run for this repository alone. The trigger has no meaning for a workflow hosted in another repository, so with the organization workflow now required it would only produce a second, duplicate run.Nothing else is touched.
Why now
The owner created
common-doc/.github(repository id 1456043346, default branchmaster) and organization ruleset 27171943, which applies to1.0.xhere with four rules:deletion,non_fast_forward,pull_requestandworkflows. Theworkflowsrule requires.github/workflows/continuous-integration.ymlatrefs/heads/masterin repository 1456043346.Pre-state, recorded before the deletion:
"head_repository":"common-doc/commondoc"and"path":".github/workflows/continuous-integration.yml", so the source was this repository, not the organization.common-doc/.githubat the required path, size 25028 bytes, so the required context has somewhere to come from.What to watch
The required check must arrive from the organization run and be named
Continuous Integration. If it does not, this pull request is the finding: the deletion is then unsafe, and the answer is not a shim or a second workflow.No merge is requested here.