Skip to content

forge: use the designated release for a tag prefix when it carries the prefix - #252

Merged
michelroegl-brunner merged 2 commits into
mainfrom
fix/tag-prefix-latest-release
Nov 13, 2026
Merged

michelroegl-brunner merged 2 commits into
mainfrom
fix/tag-prefix-latest-release

Conversation

@MickLesk

Copy link
Copy Markdown
Member

✍️ Description

With a tag prefix, the lookup skipped the release the maintainer marked as latest and sorted the last 100 releases instead. In a busy monorepo that window is too short: maplibre/martin publishes about ten releases a week across its crates, martin-v1.16.1 already sits at position 44, and the lookup would have found no martin-v release within weeks.

The designated release is now used for a prefix too, as long as its tag starts with that prefix. Another product's designated release still falls back to the sorted list.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

With a tag prefix, the lookup skipped the release the maintainer marked as
latest and sorted the last 100 releases instead. In a busy monorepo that
window is too short: maplibre/martin publishes about ten releases a week
across its crates, martin-v1.16.1 already sits at position 44, and the
lookup would have found no martin-v release within weeks.

The designated release is now used for a prefix too, as long as its tag
starts with that prefix. Another product's designated release still falls
back to the sorted list.
@github-actions

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/tag-prefix-latest-release \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/tag-prefix-latest-release/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/tag-prefix-latest-release

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@michelroegl-brunner
michelroegl-brunner merged commit 21cc468 into main Nov 13, 2026
5 checks passed
@github-actions
github-actions Bot deleted the fix/tag-prefix-latest-release branch November 14, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants