Repository navigation
db: only chmod a database credentials file that is a regular file - #253
Merged
Merged
Conversation
setup_postgresql_db, setup_mariadb_db, setup_mysql_db and prompt_password built passwords with openssl rand | tr | head, the pattern AGENTS.md forbids. They use random_password now. The three database helpers also read APPLICATION under set -u, which only an install script has. An addon (pgAdmin) calling setup_postgresql_db died with "APPLICATION: unbound variable"; the credentials file name now falls back to APP.
setup_postgresql_db, setup_mariadb_db and setup_mysql_db wrote the database password to ~/<app>.creds with the default umask, so the file was world-readable (644). It is chmod 600 now.
Scripts suppress the file with PG_DB_CREDS_FILE=/dev/null (one in ProxmoxVE and Incus, Hoppscotch and Rallly in DevScripts). The chmod 600 from the previous commit would have run on /dev/null and locked every non-root process out of it.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/db-helper-passwords \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"Swap Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/db-helper-passwords/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/db-helper-passwordsNote that Useful flags while testing
|
# Conflicts: # lib/db.func # tests/db-helper-context.sh Co-authored-by: MickLesk <47820557+MickLesk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
Scripts suppress the file with PG_DB_CREDS_FILE=/dev/null (one in ProxmoxVE and Incus, Hoppscotch and Rallly in DevScripts). The chmod 600 from the previous commit would have run on /dev/null and locked every non-root process out of it.
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.🤖 AI Assistance (X in brackets)