Repository navigation
tools: read the mounts once when emptying a target for a clean install - #254
Merged
Merged
Conversation
_cs_clean_target_dir asked mountpoint about every directory below the target, one process each. On a node_modules tree that took minutes: 277 s for 20,000 directories, against 1.5 s now. The mounts below the target are read from /proc/self/mountinfo once and pruned by path, which also catches a bind mount from the same filesystem and a mounted file. Alpine shares the same code now; busybox mountpoint missed same-filesystem bind mounts there.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/clean-target-mountinfo \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"Swap Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/clean-target-mountinfo/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/clean-target-mountinfoNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
_cs_clean_target_dir asked mountpoint about every directory below the target, one process each. On a node_modules tree that took minutes: 277 s for 20,000 directories, against 1.5 s now. The mounts below the target are read from /proc/self/mountinfo once and pruned by path, which also catches a bind mount from the same filesystem and a mounted file. Alpine shares the same code now; busybox mountpoint missed same-filesystem bind mounts there.
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.🤖 AI Assistance (X in brackets)