Skip to content

fix: pin tag-only apps with var_appversion too #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michelroegl-brunner merged 2 commits into from
Nov 13, 2026
Merged

fix: pin tag-only apps with var_appversion too #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d832cf
Pin tag-only apps with var_appversion too
MickLesk Nov 13, 2026
4aea1cc
Trim the comments to what a reader would get wrong
MickLesk Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/forge.func
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,10 +778,14 @@ _deploy_unpacked_archive() {
# - For repos that only publish tags, not GitHub Releases
# ------------------------------------------------------------------------------
fetch_and_deploy_gh_tag() {
local script_app="${NSAPP:-${app:-}}"
local app="$1"
local repo="$2"
local version="${3:-latest}"
local target="${4:-/opt/$app}"
if [[ -n "${var_appversion:-}" ]] && _forge_is_script_app "$app" "$script_app"; then
version="$var_appversion"
fi
local app_lc=""
app_lc="$(echo "${app,,}" | tr -d ' ')"
local version_file="$HOME/.${app_lc}"
Expand Down Expand Up @@ -938,10 +942,14 @@ get_latest_gl_tag() {
# (use fetch_and_deploy_gl_release for proper Releases with assets)
# ------------------------------------------------------------------------------
fetch_and_deploy_gl_tag() {
local script_app="${NSAPP:-${app:-}}"
local app="$1"
local repo="$2"
local tag_pattern="${3:-latest}"
local target="${4:-/opt/$app}"
if [[ -n "${var_appversion:-}" ]] && _forge_is_script_app "$app" "$script_app"; then
tag_pattern="$var_appversion"
fi

local app_lc=""
app_lc="$(echo "${app,,}" | tr -d ' ')"
Expand Down
20 changes: 19 additions & 1 deletion tests/forge-appversion-scope.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -uo pipefail

CORE_DIR="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")/.." && pwd)"
eval "$(awk '/^(fetch_and_deploy_release|_forge_workdir|_forge_is_script_app|_forge_descriptor|_forge_strip_v|_forge_previous_version)[(][)] [{]/,/^}/' "$CORE_DIR/lib/forge.func")"
eval "$(awk '/^(fetch_and_deploy_release|fetch_and_deploy_gh_tag|fetch_and_deploy_gl_tag|_forge_workdir|_forge_is_script_app|_forge_descriptor|_forge_strip_v|_forge_previous_version)[(][)] [{]/,/^}/' "$CORE_DIR/lib/forge.func")"

TEST_DIR="$(mktemp -d)"
trap 'rm -rf -- "$TEST_DIR"' EXIT
Expand Down Expand Up @@ -92,5 +92,23 @@ rm -rf "$TEST_DIR/opt/subwave"
deploy github subwave perminder-klair/subwave tarball latest "$TEST_DIR/opt/subwave" >/dev/null
check "a tarball whose directory is gone is deployed again" "1" "$(grep -c '^download ' "$LOG")"

get_latest_gh_tag() { echo "9.9.9"; }
get_latest_gl_tag() { echo "9.9.9"; }
tag_deploy() {
: >"$LOG"
rm -f "$HOME/.$2"
"$1" "$2" "owner/$2" "${3:-latest}" "$TEST_DIR/opt/$2" >/dev/null 2>&1
grep -o '/[^/]*\.tar\.gz$' "$LOG" | head -n1
}
export var_appversion=7.0.3
# shellcheck disable=SC2034 # read by the tag helpers
NSAPP=redmine
check "GitHub tag: the script's own app gets the pin" "/7.0.3.tar.gz" "$(tag_deploy fetch_and_deploy_gh_tag redmine)"
check "GitHub tag: another app stays on latest" "/9.9.9.tar.gz" "$(tag_deploy fetch_and_deploy_gh_tag guacd)"
check "GitLab tag: the script's own app gets the pin" "/redmine-7.0.3.tar.gz" "$(tag_deploy fetch_and_deploy_gl_tag redmine)"
check "GitLab tag: another app keeps its pattern" "/guacd-9.9.9.tar.gz" "$(tag_deploy fetch_and_deploy_gl_tag guacd 'v*')"
unset var_appversion NSAPP
check "GitHub tag: without a pin it takes the newest" "/9.9.9.tar.gz" "$(tag_deploy fetch_and_deploy_gh_tag redmine)"

echo "${passed} passed, ${failed} failed"
[[ "$failed" -eq 0 ]]
Loading