Repository navigation
Add minimal modal run to model dry deposition - #211
Merged
Merged
Conversation
…e modal run; handle input and output for processing
… default parameters
Collaborator
|
closing and reopening to trigger codecov analysis |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 77.45% 78.49% +1.04%
==========================================
Files 55 56 +1
Lines 9420 9755 +335
==========================================
+ Hits 7296 7657 +361
+ Misses 2124 2098 -26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jcurtis2
requested changes
Jun 24, 2026
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
Co-authored-by: Jeffrey Curtis <jcurtis2@illinois.edu>
jcurtis2
approved these changes
Jul 23, 2026
jcurtis2
reviewed
Aug 4, 2026
jcurtis2
pushed a commit
that referenced
this pull request
Oct 14, 2026
Extends the size-resolved dry deposition scheme from #211 to run_sect, so sectional, modal and particle-resolved runs can be compared directly. - Sectional drydep: per-bin first-order loss at the bin-center deposition velocity (single aerosol species only). - New optional do_aero_dilution (default yes, requires drydep). Setting it to no skips both background exchange and mixing-height dilution, so deposition can be isolated under a time-varying mixing height. - Coagulation can now be disabled for sectional runs. - Currently unsupported loss function constant/volume/chamber now abort in sectional and modal runs instead of silently doing nothing. - Physics change: the deposition velocity is now V_d = V_s + 1/(R_a + R_s) replacing V_s + 1/(R_a + R_s + R_a R_s V_s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.