feat: support skips for policy-manager#83
Merged
Conversation
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds first-class support for “skipped” policies in the policy-manager pipeline, allowing a policy to explicitly opt out of evidence generation via a skip field in Rego output.
Changes:
- Extend policy evaluation output (
EvalOutput) with aSkipboolean decoded from policy results. - Update
PolicyProcessor.GenerateResultsto bypass evidence creation whenskip=true. - Add unit tests covering
skip=true,skip=false, missingskipdefaulting tofalse, and validating that skip bypasses title validation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| policy-manager/policy-manager.go | Adds Skip to EvalOutput and short-circuits evidence generation when a policy result is marked skipped. |
| policy-manager/policy-manager_test.go | Adds test coverage for skip decoding and for ensuring skipped policies produce no evidence (and no title-validation errors). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior:
Debug log message: "Skipping evidence for policy {policy_file} {policy_package}: reason"