Skip to content

chore: add parellel flag for test #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gusfcarvalho merged 1 commit into from
Apr 28, 2026
Merged

chore: add parellel flag for test #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ ENVTEST_K8S_VERSION = 1.26.1
TEST_PATH ?= ./...
# Number of times to run integration tests (set >1 to hunt flakes)
INTEGRATION_RUNS ?= 1
# Optional value for go test -parallel, e.g. `make test parallel=2`
parallel ?=
GO_TEST_PARALLEL_FLAG := $(if $(parallel),-parallel=$(parallel),)

BLUE := $(shell printf "\033[34m")
YELLOW := $(shell printf "\033[33m")
Expand Down Expand Up @@ -57,15 +60,15 @@ all: build

##@ Test
.PHONY: test
test: swag ## Run tests
@if ! go test ./... -coverprofile cover.out -v; then \
test: ## Run tests
@if ! go test $(GO_TEST_PARALLEL_FLAG) ./... -coverprofile cover.out -v; then \
$(WARN) "Tests failed"; \
exit 1; \
fi ; \
$(OK) Tests passed

.PHONY: test-integration
test-integration: swag ## Run integration tests (set INTEGRATION_RUNS>1 for flakiness detection)
test-integration: ## Run integration tests (set INTEGRATION_RUNS>1 for flakiness detection)
@failed_tests=""; \
any_failure=0; \
temp_output=$$(mktemp); \
Expand All @@ -76,7 +79,7 @@ test-integration: swag ## Run integration tests (set INTEGRATION_RUNS>1 for fla
if [ "$$run" -eq "$(INTEGRATION_RUNS)" ]; then \
coverprofile_flag="-coverprofile cover.out"; \
fi; \
if ! go test $(TEST_PATH) -count=1 $$coverprofile_flag -v --tags integration 2>&1 | tee "$$temp_output"; then \
if ! go test $(GO_TEST_PARALLEL_FLAG) $(TEST_PATH) -count=1 $$coverprofile_flag -v --tags integration 2>&1 | tee "$$temp_output"; then \
$(WARN) "Tests failed on run $$run"; \
any_failure=1; \
run_failed_tests=$$(grep "^--- FAIL:" "$$temp_output" | sed 's/^--- FAIL: //'); \
Expand Down Expand Up @@ -110,7 +113,7 @@ ifndef TEST_NAME
endif
@$(INFO) "Running integration test: $(TEST_NAME) in path: $(TEST_PATH)"

@if ! go test $(TEST_PATH) -coverprofile cover.out -v --tags integration --run $(TEST_NAME); then \
@if ! go test $(GO_TEST_PARALLEL_FLAG) $(TEST_PATH) -coverprofile cover.out -v --tags integration --run $(TEST_NAME); then \
$(WARN) "Tests failed"; \
exit 1; \
fi ; \
Expand Down Expand Up @@ -138,7 +141,7 @@ lint: lint.check ## Run golangci-lint

##@ Run
.PHONY: reviewable
reviewable: lint test-integration # Ensure a PR is ready for review.
reviewable: swag lint test-integration # Ensure a PR is ready for review.
@go mod tidy

.PHONY: check-diff
Expand Down
Loading