fix: parse sso name when first_name and family_name arent given (compatibility with dex)#390
Merged
gusfcarvalho merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
…atibility with dex) Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves OIDC SSO compatibility by deriving FirstName/LastName from the name (display name) claim when structured name claims aren’t present, which matches behavior needed for providers like Dex that may omit given_name/family_name.
Changes:
- Add a fallback in
BaseOIDCProvider.GetUserInfoto split thenameclaim intoFirstNameandLastNamewhen both structured fields are empty. - Introduce
splitDisplayNamehelper for consistent splitting behavior. - Add unit tests covering the fallback behavior, preserving structured claims, and
splitDisplayNameedge cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/service/sso/providers/base_oidc.go | Adds display-name splitting fallback for missing structured OIDC name claims. |
| internal/service/sso/providers/base_oidc_test.go | Adds tests validating the new fallback and helper behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.