fix: support pull request from rulesets#15
Merged
Conversation
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the plugin’s “effective branch rules” evidence model to include pull request–related ruleset requirements, so downstream policy evaluation can reason about review requirements derived from GitHub rulesets.
Changes:
- Extend
BranchRuleEvidencewith pull request review-related fields (approving review count, stale review dismissal, code owner review requirement). - Aggregate pull request rule parameters from
github.BranchRules.PullRequestwhen building effective branch rule evidence.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
types.go |
Adds new pull request review-related fields to the branch rules evidence JSON payload. |
repository_controls.go |
Populates the new evidence fields by aggregating values across pull request rules returned by the GitHub API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+106
to
+107
| DismissStaleReviewsOnPush bool `json:"dismiss_stale_reviews_on_push,omitempty"` | ||
| RequireCodeOwnerReview bool `json:"require_code_owner_review,omitempty"` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.