Skip to content

fix: evidence links display#232

Merged
gusfcarvalho merged 2 commits into
mainfrom
gc-fix-evidence-display
May 7, 2026
Merged

fix: evidence links display#232
gusfcarvalho merged 2 commits into
mainfrom
gc-fix-evidence-display

Conversation

@gusfcarvalho
Copy link
Copy Markdown
Contributor

fix: evidence table spacing

fix: evidence table spacing
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copilot AI review requested due to automatic review settings May 7, 2026 15:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Evidence detail view to improve how linked back-matter resources are displayed, especially for text-based media, and tweaks Evidence list table spacing.

Changes:

  • Add an expand/collapse UI to render inline previews for text/*, JSON, and YAML back-matter resources in ViewView.vue.
  • Extend ViewView unit tests to cover expanding/collapsing and JSON/YAML rendering.
  • Adjust column/padding widths in EvidenceList.vue to improve table spacing.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/views/evidence/ViewView.vue Adds expandable inline rendering for text-based media resources and tracks expanded state per resource.
src/views/evidence/tests/ViewView.spec.ts Adds fixture resources + tests for expanding/collapsing and rendering text/JSON/YAML media.
src/components/EvidenceList.vue Adjusts column width and cell padding to improve list spacing/alignment.
Comments suppressed due to low confidence (1)

src/views/evidence/ViewView.vue:390

  • The download link is rendered even when the resource has no base64 payload (e.g., resources that only provide rlinks). In those cases the generated data URL becomes data:undefined;base64,undefined, producing a broken/invalid download target. Consider only rendering the download anchor when media.base64?.value (and ideally media.base64?.mediaType) is present, and handling rlinks separately (e.g., safe external link).
                <span>{{ media.title || media.uuid }}</span>
                <a
                  :download="media.title || media.uuid"
                  :href="`data:${media.base64?.mediaType};base64,${media.base64?.value}`"
                >
                  <BIconDownload />
                </a>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/views/evidence/ViewView.vue
Comment thread src/views/evidence/ViewView.vue Outdated
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@gusfcarvalho gusfcarvalho merged commit c64df12 into main May 7, 2026
6 checks passed
@gusfcarvalho gusfcarvalho deleted the gc-fix-evidence-display branch May 7, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants