Skip to content

fix(core): move RequestLocalCache dicts to __init__ to prevent cross-request cache bleed #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
japsu merged 1 commit into from
May 12, 2026
Merged

fix(core): move RequestLocalCache dicts to __init__ to prevent cross-request cache bleed #971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions kompassi/core/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,12 @@ def annotations(self):


class RequestLocalCache:
request: HttpRequest
_event_cache: dict[str, EventCache] = {}
_universe_cache: dict[int, UniverseCache] = {}

# event id -> UniverseCache
_program_universe_cache: dict[int, UniverseCache] = {}

def __init__(self, request: HttpRequest):
self.request = request
self._event_cache: dict[str, EventCache] = {}
self._universe_cache: dict[int, UniverseCache] = {}
# event id -> UniverseCache
self._program_universe_cache: dict[int, UniverseCache] = {}

def for_event(self, event: Event) -> EventCache:
if event.slug not in self._event_cache:
Expand Down
Loading