Show relative paths in acceptance test output

[simonbaird]

Just a little cosmetic tweak (which I'm not planning to make a Jira for).

Strip the working directory prefix from test file paths to display cleaner relative paths like 'features/task_validate_image.feature' instead of full absolute paths like
'/home/sbaird/path/to/conforma/cli/features/task_validate_image.feature'

[qodo-code-review]

Review Summary by Qodo

Show relative paths in acceptance test output

✨ Enhancement

Walkthroughs

Description

• Strip working directory prefix from test file paths
• Display cleaner relative paths in acceptance test output
• Improve readability of test result messages

Diagram

flowchart LR
  A["Scenario.Uri<br/>absolute path"] -- "filepath.Rel<br/>with cwd" --> B["uri variable<br/>relative path"]
  B -- "used in output" --> C["Test result message<br/>cleaner display"]

Loading

File Changes

1. acceptance/acceptance_test.go ✨ Enhancement +10/-2

Convert absolute paths to relative in test output

• Added logic to convert absolute scenario URI to relative path
• Uses os.Getwd() to get current working directory
• Uses filepath.Rel() to compute relative path from absolute path
• Updated test result output to use relative path instead of absolute path

acceptance/acceptance_test.go

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

1. Summary path not relative 🐞 Bug ✧ Quality

Description

initializeScenario prints a relativized scenario URI to /dev/tty, but still stores the original
scenario.Uri in the failure tracker, so the final FAILED SCENARIOS SUMMARY continues to show
absolute feature paths. This makes acceptance test output inconsistent and undermines the intended
cleaner relative-path display.

Code

acceptance/acceptance_test.go[R141-155]

+			// Strip the working directory prefix to show relative paths
+			uri := scenario.Uri
+			if cwd, err := os.Getwd(); err == nil {
+				if rel, err := filepath.Rel(cwd, uri); err == nil {
+					uri = rel
+				}
+			}
+
			if scenarioErr != nil {
-				fmt.Fprintf(tty, "✗ FAILED: %s (%s)\n", scenario.Name, scenario.Uri)
+				fmt.Fprintf(tty, "✗ FAILED: %s (%s)\n", scenario.Name, uri)
			} else {
-				fmt.Fprintf(tty, "✓ PASSED: %s (%s)\n", scenario.Name, scenario.Uri)
+				fmt.Fprintf(tty, "✓ PASSED: %s (%s)\n", scenario.Name, uri)
			}
			tty.Close()
		}

Evidence

The After hook computes and uses a local uri variable (possibly relative) only for the immediate
tty output, while the tracker stores scenario.Uri unchanged; later, the summary prints the stored
Location directly, so it will remain absolute even after this PR's change.

acceptance/acceptance_test.go[138-163]
acceptance/acceptance_test.go[87-110]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The After hook computes a relative `uri` for PASS/FAIL logging, but failures are tracked with `scenario.Uri` and printed later, resulting in the final failure summary still showing absolute paths.

### Issue Context
The PR goal is to show relative feature paths in acceptance test output. Currently only the /dev/tty output is updated; the end-of-run summary remains absolute.

### Fix Focus Areas
- acceptance/acceptance_test.go[138-163]
- acceptance/acceptance_test.go[87-110]

### Suggested change
- Either pass `uri` (the relativized value) into `tracker.addFailure(...)`, or
- Store both absolute and display locations, and have `printSummary` print the display version (relativized) for consistency.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more

[coderabbitai]

📝 Walkthrough

Walkthrough

The acceptance test hook is modified to compute and display relative file paths instead of absolute paths in test result messages for both FAILED and PASSED scenarios, with fallback to the original URI if path computation fails.

Changes

Cohort / File(s)	Summary
Test Logging Enhancement acceptance/acceptance_test.go	Modified test hook to use relative URI paths derived from the current working directory instead of absolute scenario URIs in both failure and success log messages, with fallback to original URI on error.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Show relative paths in acceptance test output' accurately and concisely describes the main cosmetic change in the pull request.
Description check	✅ Passed	The description clearly explains the cosmetic change, providing concrete examples of before/after path formats and the intended user benefit.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@acceptance/acceptance_test.go`:
- Around line 141-152: Normalize scenario.Uri into the local uri variable before
logging and ensure that same normalized uri is used when recording failures into
tracker; replace uses of scenario.Uri (where tracker is updated after
scenarioErr) with the normalized uri and move the normalization block so it runs
prior to both the fmt.Fprintf logging and any tracker.Record/append operations
that store the path.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fe14a6c5-2c88-4b28-a75f-06225bd8fe1a

📥 Commits

Reviewing files that changed from the base of the PR and between 3ce85d1 and 75ef6d8.

📒 Files selected for processing (1)

• acceptance/acceptance_test.go

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
acceptance	54.87% <ø> (+<0.01%)	⬆️
generative	18.14% <ø> (ø)
integration	26.99% <ø> (ø)
unit	68.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.