Skip to content

feat: wire enable_realtime into DATABASE_SETTINGS_SQL COALESCE cascade #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 2 commits into from
May 11, 2026
+6 −4
Merged

feat: wire enable_realtime into DATABASE_SETTINGS_SQL COALESCE cascade #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f13e76c
feat: wire enable_realtime into DATABASE_SETTINGS_SQL COALESCE cascade
pyramation May 11, 2026
def6aa9
fix: add enable_realtime column to test seed database_settings and ap…
pyramation May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions graphql/server-test/__fixtures__/seed/simple-seed-services/setup.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ CREATE TABLE IF NOT EXISTS services_public.database_settings (
enable_connection_filter boolean NOT NULL DEFAULT true,
enable_ltree boolean NOT NULL DEFAULT true,
enable_llm boolean NOT NULL DEFAULT false,
enable_realtime boolean NOT NULL DEFAULT false,
options jsonb NOT NULL DEFAULT '{}'::jsonb,
CONSTRAINT ds_db_fkey FOREIGN KEY (database_id) REFERENCES metaschema_public.database (id) ON DELETE CASCADE
);
Expand All @@ -320,6 +321,7 @@ CREATE TABLE IF NOT EXISTS services_public.api_settings (
enable_connection_filter boolean,
enable_ltree boolean,
enable_llm boolean,
enable_realtime boolean,
options jsonb NOT NULL DEFAULT '{}'::jsonb,
CONSTRAINT as_db_fkey FOREIGN KEY (database_id) REFERENCES metaschema_public.database (id) ON DELETE CASCADE,
CONSTRAINT as_api_fkey FOREIGN KEY (api_id) REFERENCES services_public.apis (id) ON DELETE CASCADE
Expand Down
8 changes: 4 additions & 4 deletions graphql/server/src/middleware/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,8 @@ const DATABASE_SETTINGS_SQL = `
COALESCE(aps.enable_many_to_many, ds.enable_many_to_many) AS resolved_enable_many_to_many,
COALESCE(aps.enable_connection_filter, ds.enable_connection_filter) AS resolved_enable_connection_filter,
COALESCE(aps.enable_ltree, ds.enable_ltree) AS resolved_enable_ltree,
COALESCE(aps.enable_llm, ds.enable_llm) AS resolved_enable_llm
COALESCE(aps.enable_llm, ds.enable_llm) AS resolved_enable_llm,
COALESCE(aps.enable_realtime, ds.enable_realtime) AS resolved_enable_realtime
FROM services_public.database_settings ds
LEFT JOIN services_public.api_settings aps ON ds.database_id = aps.database_id AND aps.api_id = $2
WHERE ds.database_id = $1
Expand Down Expand Up @@ -325,6 +326,7 @@ interface DatabaseSettingsRow {
resolved_enable_connection_filter: boolean;
resolved_enable_ltree: boolean;
resolved_enable_llm: boolean;
resolved_enable_realtime: boolean;
}

interface ApiListRow {
Expand Down Expand Up @@ -672,9 +674,7 @@ const toDatabaseSettings = (row: DatabaseSettingsRow | null): DatabaseSettings |
enableConnectionFilter: row.resolved_enable_connection_filter,
enableLtree: row.resolved_enable_ltree,
enableLlm: row.resolved_enable_llm,
// Reads from the COALESCE cascade once constructive-db#1105 is merged and
// the enable_realtime column exists in database_settings / api_settings.
enableRealtime: false,
enableRealtime: row.resolved_enable_realtime,
};
};

Expand Down
Loading