Fix issue #219: Add support for OBJECT_PUBLICATION in AlterOwnerStmt#225
Closed
pyramation wants to merge 3 commits into
Closed
Fix issue #219: Add support for OBJECT_PUBLICATION in AlterOwnerStmt#225pyramation wants to merge 3 commits into
pyramation wants to merge 3 commits into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Fixes issue #219 by adding OBJECT_PUBLICATION case to the AlterOwnerStmt switch statement in the deparser. This enables deparsing of ALTER PUBLICATION ... OWNER TO ... statements. Co-Authored-By: Dan Lynch <pyramation@gmail.com>
da1916c to
0d63d58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #219: Add OBJECT_PUBLICATION support to AlterOwnerStmt deparser
Summary
Adds support for deparsing
ALTER PUBLICATION ... OWNER TO ...statements by adding theOBJECT_PUBLICATIONcase to theAlterOwnerStmtswitch statement in the deparser.Changes:
OBJECT_PUBLICATIONcase inpackages/deparser/src/deparser.ts(3 lines)fix/issues-219Before: Deparser threw error:
Unsupported AlterOwnerStmt objectType: OBJECT_PUBLICATIONAfter: Successfully deparses to:
ALTER PUBLICATION "my_publication" OWNER TO "postgres"Review & Testing Checklist for Human
misc/issues-17.sqlpasses and correctly round-trips the SQL statementOBJECT_COLLATION,OBJECT_TYPE)Notes
fix/issues-219branch which already included the fixture testLink to Devin run: https://app.devin.ai/sessions/505114984e764debaca3c75b2dab458c
Requested by: Dan Lynch (pyramation@gmail.com) / @pyramation