refactor container_list_windows_test.go to use Tigron#4780
Open
must108 wants to merge 4 commits intocontainerd:mainfrom
Open
refactor container_list_windows_test.go to use Tigron#4780must108 wants to merge 4 commits intocontainerd:mainfrom
must108 wants to merge 4 commits intocontainerd:mainfrom
Conversation
Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev>
46 tasks
Contributor
Author
haytok
suggested changes
Mar 15, 2026
Member
haytok
left a comment
haytok
left a comment
There was a problem hiding this comment.
Have you already checked CI failures related to this PR?
sathiraumesh
suggested changes
Apr 10, 2026
Signed-off-by: must108 <mustaeen18@gmail.com>
Signed-off-by: Mustaeen Ahmed <contact@mustaeen.dev>
must108
force-pushed
the
containers-list-windows-test
branch
from
189b030 to
374029c
Compare
haytok
reviewed
Apr 23, 2026
| size, _ := tab.ReadRow(lines[1], "SIZE") | ||
| assert.Assert( | ||
| t, | ||
| strings.Contains(size, "(virtual"), |
Member
There was a problem hiding this comment.
Originally, the string was checked to see if it contained "36.0 MiB (virtual ", but is there a reason for this?
Comment on lines
+68
to
+70
| if !restart { | ||
| args = append(args, "--restart=no") | ||
| } |
Member
There was a problem hiding this comment.
Could we move the --restart=no append above the --name / image block? Otherwise, when restart is false, the container exits immediately instead of running with --restart=no.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests now use
nerdtest.Setup, and TigronResolvesUpdates (EDIT: @AkihiroSuda) #4613