feat(admin): allow admins to confirm users and set passwords by rewritten · Pull Request #834 · coopdevs/timeoverflow

rewritten · 2026-03-26T13:24:35Z

Summary

Closes #821

New user form: adds optional Password / Password confirmation fields and a Confirm immediately checkbox — when checked, the user is created already confirmed without needing a working SMTP setup
Show page: adds a "Confirm user" action button that appears only for unconfirmed users, allowing admins to confirm them at any time via a PUT /admin/users/:id/confirm action
User index: shows confirmed_at column so confirmation status is visible at a glance
All 8 locales updated with the new keys

Test plan

Create a new user via admin without checking "Confirm immediately" — user should be unconfirmed, "Confirm user" button should appear on their show page
Create a new user with "Confirm immediately" checked — confirmed_at should be set, no confirmation email required
Create a new user with a password set — user should be able to log in with that password
Click "Confirm user" on an unconfirmed user's show page — confirmed_at should be set and the button should disappear
Edit an existing user leaving password blank — password should not be changed
Edit an existing user with a new password — password should be updated

🤖 Generated with Claude Code

Admins can now create users that are already confirmed (bypassing email confirmation) and optionally set a password at creation time. Existing unconfirmed users can be confirmed via a dedicated action button on their show page. Confirmed-at timestamp is also shown in the user index. Closes coopdevs#821 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Adds admin-side controls to confirm users and optionally set passwords at creation time, reducing reliance on SMTP for provisioning accounts (Issue #821).

Changes:

Adds an admin “Confirm user” action and shows confirmed_at in the admin users index.
Extends the ActiveAdmin user form to optionally set password/password confirmation and “Confirm immediately” on create.
Updates all locales with new i18n keys for the added admin UI.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
config/locales/pt-BR.yml	Adds i18n keys for confirm actions and “confirm immediately”.
config/locales/ja.yml	Adds i18n keys for confirm actions and “confirm immediately”.
config/locales/gl.yml	Adds i18n keys for confirm actions and “confirm immediately”.
config/locales/fr.yml	Adds i18n keys for confirm actions and “confirm immediately”.
config/locales/eu.yml	Adds i18n keys for confirm actions and “confirm immediately”.
config/locales/es.yml	Adds i18n keys for confirm actions and “confirm immediately”.
config/locales/en.yml	Adds i18n keys for confirm actions and “confirm immediately”.
config/locales/ca.yml	Adds i18n keys for confirm actions and “confirm immediately”.
app/models/user.rb	Introduces `confirm_immediately` virtual attribute used during admin create.
app/admin/user.rb	Adds confirm member action, `confirmed_at` column, password fields, and create/update overrides for confirmation/password handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

app/models/user.rb

app/admin/user.rb

Copilot · 2026-03-26T13:28:44Z

app/admin/user.rb

+  member_action :confirm, method: :put do
+    resource.confirm!
+    redirect_to admin_user_path(resource), notice: I18n.t("active_admin.users.confirmed_notice")
+  end


New admin behaviors are introduced here (manual confirmation endpoint and the ability to set/retain passwords via the ActiveAdmin form/controller overrides) but there are no specs covering them. Adding request/controller specs around PUT /admin/users/:id/confirm, create with/without confirm_immediately, and update with blank vs non-blank password would help prevent regressions (especially around Devise confirmable).

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

decentral1se · 2026-03-30T16:39:03Z

Thanks for much for undertaking this work 💟 When this is merged, we will put it to good use basically immediately and begin testing it. We can deploy these changes for our testing phase coming up soon in April here in Rotterdam 🎉

decentral1se · 2026-04-01T14:36:09Z

Hey @rewritten, do you have a ETA for merging this change? And in general, when the list of fixes in #830 #831 #832 #833 will be merged? Thanks in advance.

sseerrggii · 2026-04-05T10:34:18Z

Testing at https://staging.timeoverflow.org

Change user password works fine ✔️

But when I tried to confirm user I got an Error 500 response and the user doesn't seem to be confirmed

https://staging.timeoverflow.org/admin/users/22/confirm

rewritten · 2026-04-05T13:47:39Z

Hey @rewritten, do you have a ETA for merging this change? And in general, when the list of fixes in #830 #831 #832 #833 will be merged? Thanks in advance.

Hey @decentral1se I do not have merge authorization on this repository, likey @sseerrggii or @markets can merge when it passes QA (which it does not at the momet...)

markets · 2026-04-06T21:14:31Z

Really happy to merge it after QA approves ✅ 👌

Replace Devise's `confirm` (which requires a pending token and triggers email callbacks) with `skip_confirmation!` + `save`, so the admin action directly sets confirmed_at without any email side-effects. Also updates specs to reflect the correct behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

sseerrggii · 2026-04-07T07:43:33Z

Now it works fine! Thanks @rewritten

✔️

markets · 2026-04-07T09:48:35Z

@rewritten @sseerrggii Sorry 🙏🏼 I already merged this one, but I just realized we missed to add the new translation keys in WTI. Could you please add these 3 new keys?

decentral1se · 2026-04-07T16:24:51Z

I ran on the develop branch:

➜ timeoverflow develop ✓ wti push
# Pushing files on TimeOverflow
 config/locales/en.yml                              | b36db3a..3793ea9  Accepted

wti diff did report 3 missing keys. I hope that was what you intended!

markets · 2026-04-07T16:51:57Z

@decentral1se I just fixed it (474b012), the problem was: you pushed only the target locale... Fortunately I have the most recent copy of each file in my local machine:

 wti push -l "es ca eu gl en pt-BR fr ja nl-NL"

I think the best (less dangerous) workflow is to update stuff always in the web UI and just use the wti pull to sync.

decentral1se · 2026-04-08T06:41:12Z

Thanks @markets! I will only use the web UI / wti pull from now on.

Copilot AI review requested due to automatic review settings March 26, 2026 13:24

Copilot started reviewing on behalf of rewritten March 26, 2026 13:25 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Update app/models/user.rb

656a83b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

markets approved these changes Apr 3, 2026

View reviewed changes

Fix controller + add tests

f57fa9b

markets merged commit eea06a5 into coopdevs:develop Apr 7, 2026
2 checks passed

decentral1se mentioned this pull request Apr 10, 2026

i18n: add missing translations #843

Merged

Conversation

rewritten commented Mar 26, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

decentral1se commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

decentral1se commented Apr 1, 2026

Uh oh!

sseerrggii commented Apr 5, 2026

Uh oh!

rewritten commented Apr 5, 2026

Uh oh!

markets commented Apr 6, 2026

Uh oh!

sseerrggii commented Apr 7, 2026

Uh oh!

Uh oh!

markets commented Apr 7, 2026

Uh oh!

decentral1se commented Apr 7, 2026

Uh oh!

markets commented Apr 7, 2026

Uh oh!

decentral1se commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

decentral1se commented Mar 30, 2026 •

edited

Loading