Repository navigation
Add --wait-for-workers for work queue workers through makeflow - #4546
Merged
Merged
Conversation
Member
|
This looks good -- but while you are at it, can you add the same pass-through to |
RHartung-ND
marked this pull request as draft
October 23, 2026 21:42
Member
Author
|
I just pushed an update that replicates the change for TaskVine as well. Let me know if everything looks good! |
RHartung-ND
marked this pull request as ready for review
October 24, 2026 20:14
btovar
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Context:
Makeflow had an unadvertised --wait-queue-size option that was stored as a batch option but never read by any driver, so there was no way to make a Makeflow-driven manager hold dispatch until N workers connected. Passing --wait-for-workers failed with "unrecognized option".
Changes:
Added --wait-for-workers. Work Queue batch drivers apply it with the manager's "wait-for-workers" tune.
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.