Repository navigation
Wrapper input - #4553
Merged
Merged
Wrapper input#4553
Conversation
Since the batch interface rework (cooperative-computing-lab#3898), batch_wrapper_write lists the wrapper it creates as an input of the task. The makeflow hooks that write a wrapper (resource monitor, docker, singularity, sandbox, enforcement, umbrella, vc3 builder) then add the same file again through makeflow_hook_add_input_file. Under -T vine the task then has two identical input mounts. The worker returns such a task as forsaken and makeflow resubmits it without end, so `--monitor` and `--allocation` do not work with TaskVine. makeflow_hook_add_input_file now skips an input that is already listed with the same outer and inner names.
If a task already lists a file with the same inner and outer name, the repeated file is ignored. If it lists a different outer name for the same inner name, this is a fatal error.
Member
Author
|
Thank you again @ZacKienzle2! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second part of #4544
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.