Repository navigation
Add pixi-pack support to poncho_package_run - #4557
saifulislampi wants to merge 1 commit into
Conversation
| if ! PIXI_UNPACK=$(find_pixi_unpack) | ||
| then | ||
| errmsg "pixi-pack archive detected, but pixi-unpack was not found." | ||
| errmsg "Stage pixi-unpack beside poncho_package_run or set PONCHO_PIXI_UNPACK." |
There was a problem hiding this comment.
I think that if pixi-unpack is not inside the expanded directory, then it is not a valid poncho package in pixi format? The only things you should need for poncho are tar + decompress tool + poncho_package_run + tarball?
|
|
||
| # force no args to activate, as it wants to consume "$@" which contains the command line | ||
| source "${UNPACK_TO}/bin/activate" "" | ||
| if [[ "${PACKAGE_FORMAT}" = pixi-pack ]] |
There was a problem hiding this comment.
poncho packages are not conda packages. They are constructed with some other support with environment variables, etc. This pr wants to support pixi-pack environments directly?
I rather have poncho_package_create modified to get an argument --format conda or pixi and modify poncho_package_run as little as possible.
There was a problem hiding this comment.
💯 Poncho packages should be opaque, self-contained objects that require only poncho_package_run to deploy.
Summary
Add initial
pixi-packsupport toponcho_package_runwhile preserving theexisting
conda-packbehavior.For a Pixi archive, the runner:
pixi-pack.json;pixi-unpackexecutable;pixi-unpackis transferred using the existing factory option:Test scenario
Import an
environment.yml, create the Pixi environment, and pack it:Then start the factory:
Current limitation
pixi-unpackmust currently be supplied explicitly with--wrapper-input.Factory-side automatic staging can be added separately.