Skip to content

updateDatos#13

Open
netpoe wants to merge 6 commits into
corecodeio:masterfrom
danbart:master
Open

updateDatos#13
netpoe wants to merge 6 commits into
corecodeio:masterfrom
danbart:master

Conversation

@netpoe
Copy link
Copy Markdown

@netpoe netpoe commented Jun 19, 2020

No description provided.

@saullopezc
Copy link
Copy Markdown

Hola @danbart,
Excelente inicio, revisa y resuelve los comentarios a continuación.

Comment thread src/client.ts Outdated
Comment thread src/client.ts Outdated
Comment thread src/index.ts
Copy link
Copy Markdown
Author

@netpoe netpoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danbart muy cerca.
Resuelve los últimos comentarios.

instala la extensión prettier en tu editor.

Igualmente agrega esto a tu settings.json:

"editor.codeActionsOnSave": {
    "source.organizeImports": true
  },

Comment thread src/data.ts Outdated
Comment thread src/data.ts Outdated
danbart and others added 2 commits June 19, 2020 22:04
sugerencia

Co-authored-by: Gus <gus@developermexicano.com>
Copy link
Copy Markdown

@saullopezc saullopezc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resuelve los siguiente comentarios

Comment thread package.json Outdated
Comment thread yarn.lock Outdated
Comment thread src/data.ts Outdated
Copy link
Copy Markdown
Author

@netpoe netpoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saullopezc gracias por tu feedback.

@danbart buen trabajo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants