ci: run additional bootupd related tests from fedora-coreos-config#1104
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes a RAID1 bootupd test from this repository and updates the Jenkinsfile to target external bootupd and boot tests instead. A review comment points out that the updated pattern ext.bootupd.* will not match the external tests, which are prefixed with ext.config., and suggests changing it to ext.config.bootupd.* to ensure the tests are executed.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| shwrap("cosa build && cosa osbuild qemu") | ||
| // bootupd really can't break upgrades for the OS | ||
| kola(cosaDir: "${env.WORKSPACE}", extraArgs: "ext.*bootupd* --qemu-firmware=uefi", skipUpgrade: true, skipBasicScenarios: true) | ||
| kola(cosaDir: "${env.WORKSPACE}", extraArgs: "ext.bootupd.* ext.config.boot.* --qemu-firmware=uefi", skipUpgrade: true, skipBasicScenarios: true) |
There was a problem hiding this comment.
The pattern ext.bootupd.* will not match the bootupd tests defined in fedora-coreos-config. External tests from the configuration repository are prefixed with ext.config., meaning those tests are registered as ext.config.bootupd.*.
Since the raid1 test has been removed from this repository, there are likely no tests remaining that match ext.bootupd.* directly. To ensure the bootupd tests from fedora-coreos-config are executed, please update the pattern to ext.config.bootupd.*.
kola(cosaDir: "${env.WORKSPACE}", extraArgs: "ext.config.bootupd.* ext.config.boot.* --qemu-firmware=uefi", skipUpgrade: true, skipBasicScenarios: true)
There was a problem hiding this comment.
See coreos/coreos-assembler#4550 (comment)
The remaining test would be ext.bootupd.test-bootupd
|
Looks like it's correctly matching the desired tests: And they all passed. |
Rolv-Apneseth
force-pushed
the
run-fcos-ci
branch
from
4d7acbb to
6d3ca25
Compare
2 participants
From discussion in coreos/coreos-assembler#4550, try to run more
bootupdrelated tests from fedora-coreos-config in the CI forbootupd.We can also drop the
raid1test as it is included infedora-coreos-config: https://github.com/coreos/fedora-coreos-config/tree/testing-devel/tests/kola/boot/raid1-boot