Sort upperBound by ascending order in mergeHistogram#7378
Open
SungJin1212 wants to merge 1 commit intocortexproject:masterfrom
Open
Sort upperBound by ascending order in mergeHistogram#7378SungJin1212 wants to merge 1 commit intocortexproject:masterfrom
SungJin1212 wants to merge 1 commit intocortexproject:masterfrom
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed the
TestMergeHistogramis flaky. The reason ismergeHistogram()merged classic histogram buckets via a map[float64]uint64 (bucketMap), since Go map iteration is non-deterministic, the resulting bucket order could vary.This PR sorts by
Bucket.UpperBoundin ascending order and keeps the output stable.Related Log
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]